- First commit to issue fork.
- 🇩🇪Germany FalkNisius Berlin
Sorry, that I react late. Thanks for the work.
My team runs in the issue with missing width and height, and the approach should be changed.
The actual code prefers the width and height attribute from the svg-tag. Most exporters write 100% to that attributes, and it results to a width and height of 100 pixel, because the code strips the % sign.
The viewBox attribute is more usual and should be preferred if it exists.
The code depends on the letter case of the attributes, that is not always given, that viewBox is written as camel case.
The first two values of viewBox should not be ignored, they can have positive and negative values. The values in the viewBox can be float. We have to build a difference between the right and left corner values. At least the absolute values of the difference should be used.
- Status changed to Needs work
5 months ago 8:24am 4 July 2024 - 🇵🇱Poland bronismateusz
I tested patch #4 and it only works when the image style uses crop or scale and crop. Then the values for width and height are actually passed on correctly. If these filters are not applied, then these attributes are missing, for the img field.
In addition, I also see that the rotate or desaturate filter does not work either. - 🇵🇱Poland bronismateusz
I have prepared a patch that fixes the addition of width and height attributes for the other filters in the image style.
- 🇨🇿Czech Republic milos.kroulik
milos.kroulik → made their first commit to this issue’s fork.
- Merge request !32- make a more robust implementation of detecting size from svg file → (Open) created by milos.kroulik