- Issue created by @milos.kroulik
- Status changed to Needs review
5 months ago 8:24pm 10 February 2024 - 🇨🇿Czech Republic milos.kroulik
I tried to fix the found issue. I will re-activate issue, if I will find something else.
The CSS approach for the MR is not the way moving forward, and having
!importantfor anything should be a last resort- Status changed to Needs work
5 months ago 7:48am 11 February 2024 - 🇨🇿Czech Republic milos.kroulik
The CSS approach for the MR is not the way moving forward
Sorry, is there any developer documentation I can study to do better next time?
having !important for anything should be a last resort
I know, I used it purely because Bootstrap uses it for
text-mutedclass and I don't know how to handle it differently. Not sure of any documentation regarding this, but for Radix, we are a base theme, so we shouldn't be considering CSS styles much into the core of the theme, since its all UI preferences, and since we are talking Bootstrap, everything is overridable via variables if it comes to the CSS
Not saying that any CSS changes are wrong, just it should ideally be the last resort if all else fails, for instance the first thing that pops into my head is to get rid of the class applied to the element rather than changing the color of
text-muted