Remove service location anti-patterns in constructors: language

Created on 27 May 2023, almost 2 years ago

Updated 31 May 2023, almost 2 years ago

@mglaman pointed out the possible problem of these three patterns in the class constructor in his blog:
$this->request = $request_stack->getCurrentRequest();
$this->nodeStorage = $entity_type_manager->getStorage('node');
$this->config = $config_factory->get('mymodule.settings');

the following classes are affected:
Drupal\language\Form\NegotiationConfigureForm

📌 Task

Status

Needs work

Version

11.0 🔥

Component

Language system →

Last updated 7 days ago

Maintained by
🇩🇪Germany @sun

Created by

🇩🇪Germany sleitner

Live updates comments and jobs are added and updated live.

Needs Review Queue Initiative
Used to track the progress of issues reviewed by the Drupal Needs Review Queue Initiative.

Needs issue summary update
Issue summaries save everyone time if they are kept up-to-date. See Update issue summary task instructions.

Comments & Activities

Issue created by @sleitner
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update almost 2 years ago
29,401 pass
@sleitner opened merge request.
Issue was unassigned.
Status changed to Needs review almost 2 years ago8:23pm 28 May 2023
Comment almost 2 years ago →
🇩🇪Germany sleitner
Status changed to Needs work almost 2 years ago6:24pm 31 May 2023
Comment almost 2 years ago →
🇺🇸United States smustgrave
Missed one sorry

Think the issue summary should be updated using the default template

What article?
Why is this a problem?
How does this make things better?

Should be included as part of the issue summary.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024