Remove service location anti-patterns in constructors: comments

Created on 27 May 2023, over 1 year ago

Updated 1 June 2023, over 1 year ago

@mglaman pointed out the possible problem of these three patterns in the class constructor in his blog:
$this->request = $request_stack->getCurrentRequest();
$this->nodeStorage = $entity_type_manager->getStorage('node');
$this->config = $config_factory->get('mymodule.settings');

The following classes are affected:
$config_factory->get():
Drupal\comment\CommentManager

$entity_type_manager->getStorage():
Drupal\comment\Form\CommentAdminOverview
Drupal\comment\Plugin\Field\FieldFormatter\CommentDefaultFormatter

📌 Task

Status

Needs work

Version

11.0 🔥

Component

Comment →

Last updated 18 days ago

Maintained by
🇦🇺Australia @larowlan
🇫🇷France @andypost

Created by

🇩🇪Germany sleitner

Live updates comments and jobs are added and updated live.

Needs Review Queue Initiative
Used to track the progress of issues reviewed by the Drupal Needs Review Queue Initiative.

Needs issue summary update
Issue summaries save everyone time if they are kept up-to-date. See Update issue summary task instructions.

Comments & Activities

Issue created by @sleitner
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
Custom Commands Failed
@sleitner opened merge request.
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
29,401 pass
Issue was unassigned.
Status changed to Needs review over 1 year ago8:24pm 28 May 2023
Comment over 1 year ago →
🇩🇪Germany sleitner
Status changed to Needs work over 1 year ago10:11pm 1 June 2023
Comment over 1 year ago →
🇺🇸United States smustgrave
Missed one sorry

Think the issue summary should be updated using the default template

What article?
Why is this a problem?
How does this make things better?

Should be included as part of the issue summary.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024