- Issue created by @douggreen
- Merge request !6833Issue #3424720 - don't unnecessarily add domain to outbound URL's in LanguageNegotationUrl. → (Closed) created by douggreen
- 🇺🇸United States xjm
Thanks for reporting this!
The merge request needs to be created against 11.x (our main development branch); it will be backported to supported versions once committed to 11.x. In some cases the easiest thing to do is close the previous merge request and create a new one against 11.x. Thanks!
- First commit to issue fork.
- Status changed to Needs review
9 months ago 9:07am 7 June 2024 - Status changed to Needs work
9 months ago 1:43pm 7 June 2024 - First commit to issue fork.
- 🇪🇸Spain vidorado Logroño (La Rioja)
I've added test coverage.
As a bonus, it turns out that we've fixed, at least partially, a bug stated in 🐛 Domain-based language negotiation strips "destination" URL query argument, causing BigPipe error Closed: duplicate , so I have had to change a line in
BlockUiTest
too. - 🇺🇸United States smustgrave
Left 1 small comment on MR
If you are another contributor eager to jump in, please allow the previous poster at least 48 hours to respond to feedback first, so they have the opportunity to finish what they started!
- 🇪🇸Spain vidorado Logroño (La Rioja)
Thanks! I've replied to your comment in the MR.