The Needs Review Queue Bot → tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- 🇫🇷France raphaelbertrand Lauris
Simplier solution might be to change this line (61) in big_pipe.module,
method big_pipe_page_attachments to set destination parametter to local uri instead of absolute
by the way it will not be detected as external. The right host be already set by the route of big_pipe.nojs .'content' => '0; URL=' . Url::fromRoute('big_pipe.nojs', [], ['query' => \Drupal::service('redirect.destination')->getAsArray()])->toString(),
- 🇮🇳India sukr_s
This issue is resolved if solution in #3424701-30: Cannot delete file when using language negotiation domains → is accepted.
- Status changed to Postponed
7 months ago 1:41pm 13 May 2024 - 🇺🇸United States smustgrave
Think this would be a good plan. Lets postpone this one for the fix in 🐛 Cannot delete file when using language negotiation domains Active then we can reopen this one for expanding test coverage and removing the todo in the code.
- Status changed to Closed: duplicate
7 months ago 3:57pm 3 June 2024 - 🇺🇸United States smustgrave
So the fix in #44 needed to update the tests too. So going to close as duplicate and move over credit.