- Issue created by @alex.bukach
- šŗšøUnited States mlncn Minneapolis, MN, USA
Does anything happen with the module, or is the included library the only thing that needs changes?
(And any tips for swapping or patching plugins in the project composer.json to test this more easily?)
- š©šŖGermany sleitner
Breaks all my sites. Only workaround is go back to 10.4.8 or 11.1.8
- šÆš“Jordan Rajab Natshah Jordan
I confirm the issue, Breaks all my sites too
Drupal 10 and Drupal 11 - šÆš“Jordan Rajab Natshah Jordan
- šÆš“Jordan Rajab Natshah Jordan
Hoping for a release, otherwise it will be forced to start a fork.
- šÆš“Jordan Rajab Natshah Jordan
Forked the northernco/ckeditor5-anchor-drupal library as vardot/ckeditor5-anchor-drupal
Working to release 1.0.0 for old work from the old repo
and 2.0.0 for any Additions/Changes/Updates/Fixes
To work with composer directly ( super fast to install ) - šÆš“Jordan Rajab Natshah Jordan
ā Released vardot/ckeditor5-anchor-drupal 2.0.0
https://packagist.org/packages/vardot/ckeditor5-anchor-drupal#2.0.0
https://github.com/Vardot/ckeditor5-anchor-drupal/releases/tag/2.0.0Install with Composer
composer require vardot/ckeditor5-anchor-drupal:~2.0
Switching to require the library directly in the
composer.json
file for the module - šÆš“Jordan Rajab Natshah Jordan
Thank you Alex.
I committed your PR into the new repo
https://github.com/Vardot/ckeditor5-anchor-drupal/commit/b91c8b28298e43f... -
rajab natshah ā
committed 76346aca on 3.0.x
Issue #3529625: Add vardot/ckeditor5-anchor-drupal to support CKEditor5...
-
rajab natshah ā
committed 76346aca on 3.0.x
- šÆš“Jordan Rajab Natshah Jordan
Tested in both Drupal 10 and Drupal 11
onlycomposer require drupal/anchor_link
No further requirements
- š§šŖBelgium tom verhaeghe
I checked and I can confirm that it works.
Thank you for the quick action! - šÆš“Jordan Rajab Natshah Jordan
Thanks, Tom, for the post release testing
- šŗšøUnited States aaronpinero
Thank you for getting this fixed so quickly.
- šÆš“Jordan Rajab Natshah Jordan
ā Released anchor_link-3.0.0 ā
do a basiccomposer update drupal/anchor_link
No need for the old library.Requirements
This plugin uses an external CKEditor5 library: Anchor Link CKEditor plugin
It is required in the module. No need to require it anymore.Installation
Require the CKEditor Anchor Link modulecomposer require drupal/anchor_link:~3.0
Enable the Anchor Link module with Drush
drush en anchor_link
- šŗšøUnited States alfattal Minnesota
In reference to comment #23 ⨠Support CKEditor5 45.2.0 Needs review , I'm on Drupal 10.4.7 and I can confirm that the CKEditor toolbar does not appear after upgrading to this version. I did basic
composer update drupal/anchor_link -W
which installedvardot/ckeditor5-anchor-drupal (2.0.1)
automatically. - šÆš“Jordan Rajab Natshah Jordan
Fareed, Hope that you can update to ~10.5.0 or ~11.2.0
You can keep using the library you like.
Replace the one you no longer want.
"replace": { "vardot/ckeditor5-anchor-drupal": "*" }
or
"replace": { "npm-asset/northernco--ckeditor5-anchor-drupal": "*" }
I will not make any further changes to this issue.
Feel free to file a new follow-up issue. ( I have an idea to manage a smoother upgrade process )
Let do it in the new issue - šŗšøUnited States alfattal Minnesota
@rajab natshah I've updated Drupal core to
10.5.1
and the issue persist. Also, there is already a ticket for the broken toolbar display Missing icon (pencil) is breaking CKEditor5 š Missing icon (pencil) is breaking CKEDitor5 Active that needs your attention. - šŗšøUnited States joelsteidl
In my case,
composer.lock
was still maintaining a reference to the older https://registry.npmjs.org/@northernco/ckeditor5-anchor-drupal/-/ckedito...Once that was removed, the issue resolved. Worth looking at.
- šÆš“Jordan Rajab Natshah Jordan
Thanks, for testing and feedback
- Issue
#3533770 ā
: Added support for Drupal
^9 || <=10.4 || <=11.1
and>=10.5 || >=11.2
ā Released anchor_link-3.0.1 ā
- Issue
#3533770 ā
: Added support for Drupal
- šŗšøUnited States joelsteidl
In case this bites anyone else.
/libraries/ckeditor5-anchor-drupal/.gitignore
has it's own.gitignore
file ignoring the/libraries/ckeditor5-anchor-drupal/build
directory. We are running a build step in a pipeline and the.gitignore
was preventing the javascript to land on the server. - š§šŖBelgium weseze
Ran into #31: this is a critical bug since the missing JS file will break ckeditor... Even worse if you run JS aggregation (which you should on production). Might break the entire site.
- šÆš“Jordan Rajab Natshah Jordan
I see this.
Thanks, Joel, Wesley.
Removing the.gitignore
from the library. - šÆš“Jordan Rajab Natshah Jordan
- Cleanup: Removed leftover files from NPM packaging after switching to Composer #13
ā Released Vardot/ckeditor5-anchor-drupal 2.0.3
- Works with Drupal>=10.5 || >=11.2
ā Released Vardot/ckeditor5-anchor-drupal 1.0.3
- Works with Drupal^9 || <=10.4 || <=11.1
Doing the change to
^1.0.3 || ^2.0.3
- šÆš“Jordan Rajab Natshah Jordan
ā Released anchor_link-3.0.3 ā
- Issue #3534149 ā by hosterholz ā : Prevent Updates from vardot/ckeditor5-anchor-drupal 1.0.2 to 2.0.1
- š§šŖBelgium weseze
Thanks for the quick response and fix! Much appreciated.