Account created on 24 November 2009, over 14 years ago
#

Merge Requests

Recent comments

🇺🇸United States joelsteidl

Thanks @SocialNicheGuru! So just confirming that this is a PHP 8.2 issue?

🇺🇸United States joelsteidl

Additional edits

🇺🇸United States joelsteidl

minor edit

🇺🇸United States joelsteidl

further examples

🇺🇸United States joelsteidl

updating examples

🇺🇸United States joelsteidl

I need more information. Can you post a code example that was causing the deprecated function? Zoom API Module and APITools are not setting an $id property. Are you setting one?

🇺🇸United States joelsteidl

I just updated the mergevars description in the merge request. Happy to make that change elsewhere if it makes sense.

FYI, I'm on Drupal 10.1.x where I was having that issue.

🇺🇸United States joelsteidl

@BWilliams1992 is on to something with the javascript getting included twice. This module needs some love.

This refactor is headed in the right direction but wasn't working for me. https://www.drupal.org/project/gtranslate/issues/3346829 🐛 Refactor to use libraries and compatibility with Big Pipe Needs work

My sinful quick fix for now. If the block is found more than once I'm just doing a string replace to remove the javascript from getting added again. Be sure you pay attention to which widget you are using.

function hook_preprocess_block(&$variables) {
  if ($variables['plugin_id'] == 'gtranslate_block') {
    if (isset($variables['attributes']['id']) && $variables['attributes']['id'] != 'block-gtranslate') {
      // Hack to remove the script tag from the gtranslate block if included more
      // than once on the page. See https://www.drupal.org/project/gtranslate/issues/3396734.
      $script = "<script>(function(){var js = document.createElement('script');js.setAttribute('src', 'https://cdn.gtranslate.net/widgets/latest/ln.js');js.setAttribute('data-gt-orig-url', '/');js.setAttribute('data-gt-orig-domain', 'tpa.lndo.site');document.body.appendChild(js);})();</script>";
      $variables['content']['#gtranslate_html'] = str_replace($script, '', $variables['content']['#gtranslate_html']);
    }
  }
}
🇺🇸United States joelsteidl

Hi @kathc. Sorry for the delayed response. You would need to implement your own slideshow solution (javascript, etc) as this is mainly taking care of the administrative side of things.

🇺🇸United States joelsteidl

Adding a new step.

🇺🇸United States joelsteidl

2.0.x Version is no longer viable because of Zoom API changes. Closing.

🇺🇸United States joelsteidl

2.0.x Version is no longer viable because of Zoom API changes. Closing.

🇺🇸United States joelsteidl

Committed to dev and will be part of 3.0.0-alpha3 soon.

🇺🇸United States joelsteidl

Committed to dev and will be part of 3.0.0-alpha3 soon.

🇺🇸United States joelsteidl

@lalustine Thanks for testing the patch.

Can you post your code for the failure?

🇺🇸United States joelsteidl

@COBadger, did you happen to see https://www.drupal.org/project/views_filters_summary/issues/3345403 🐛 Remove link removes all filters Needs review

I'm wondering if you could test to see if it also resolves your issue.

🇺🇸United States joelsteidl

Since this was such a minor change and it's been tested in production, I went ahead and merged. Available on the 8.x-1.x-dev branch.

🇺🇸United States joelsteidl

I updated the merge request with some very minor tweaks.

🇺🇸United States joelsteidl

I second this! Thank you!

🇺🇸United States joelsteidl

joelsteidl made their first commit to this issue’s fork.

🇺🇸United States joelsteidl

The changes are working well on Drupal 9 https://git.drupalcode.org/project/entity_overlay/-/merge_requests/1#not...

I will post back once tested on Drupal 10.

🇺🇸United States joelsteidl

joelsteidl made their first commit to this issue’s fork.

🇺🇸United States joelsteidl

I'm going to try the service provider route, at least until 3.1.0 and then possible deprecate that.

In the meantime, if anyone hits this error, I was able to enable apitools with drush even after upgrading with composer to 3.x.

🇺🇸United States joelsteidl

Thanks @layalk! The patch solved the issue for me.

🇺🇸United States joelsteidl

Please checkout the 3.0 alpha release https://www.drupal.org/project/stories

This should be easier for folks to test without the complex composer workaround.

🇺🇸United States joelsteidl

Thanks @attheshow and @keiserjb!

I tested this out on a pretty stock D10 site. It's a bit hard to test (with composer) since it modifies the info.yml file. This is how I went about it.

I followed the steps outlined here for this module. https://gorannikolovski.com/blog/how-to-upgrade-drupal-9-to-10#how-to-in...

In my composer.json, I specified that stories be installed from source so the Drupal.org packaging wouldn't be included.

    "preferred-install": {
        "drupal/stories": "source",
        "*": "auto"
    },

I added the patch:

        "patches": {
            "drupal/stories": {
                "#3350002 - D10 Compatibility": "https://www.drupal.org/files/issues/2023-06-02/3350002-d10-compatibility-10.patch"
            }
        },

I'm going to go ahead and make an alpha 3.0.x release since one never existed.

🇺🇸United States joelsteidl

Hi @SocialNicheGuru

It makes sense to me that you could leverage Zoom API module for handling the configuration of the API connection. What further collaboration do you see?

🇺🇸United States joelsteidl

Please checkout the 3.0.x Alpha version. Open up issues if you have any.

🇺🇸United States joelsteidl

Giving a more clear title

🇺🇸United States joelsteidl

Thanks so much for following up!

Good feedback on apitools.

I'll look at getting a stable release up for that and and Zoom API 3.x. I might go straight for a stable sense the API changes on the Zoom side are required.

🇺🇸United States joelsteidl

@pixiekat Thanks so much for testing things out. I'm curious if you've had any issues so far.

🇺🇸United States joelsteidl

Hi Mark!

I think you are right...it looks to be as easy as updating the .info.yml file.

Shockingly, all the modules in composer.json have D10 compatible versions.

I do wonder if we should drop D8 support in the same commit.

If you have time to test the patch, please do. I imagine this will get committed pretty soon.

🇺🇸United States joelsteidl

That should be the case. Guzzle will automatically format the JSON.

Let me know if that isn't the case.

🇺🇸United States joelsteidl

We have a dev release up for 3.x!

composer require 'drupal/zoomapi:3.0.x-dev@dev'

Please take a look at the 2.x to 3.x documentation and let us know if you have any immediate questions.

We'll continue to work towards a stable release closer to June.

🇺🇸United States joelsteidl

description update

🇺🇸United States joelsteidl

Minor code change.

🇺🇸United States joelsteidl

minor tweaks

🇺🇸United States joelsteidl

Adding composer info

🇺🇸United States joelsteidl

Providing more clear documentation.

🇺🇸United States joelsteidl

Updating some code examples.

🇺🇸United States joelsteidl

Minor edit

🇺🇸United States joelsteidl

The 3.x version is just about ready for testing. https://git.drupalcode.org/project/zoomapi/-/tree/3.0.x

I will be working on documentation for converting from 2.x to 3.x.

Zoom has also made a lot of changes with Webhook validation that will become default in October 2023, so a lot of that is part of 3.x as well.

🇺🇸United States joelsteidl

This change is available in the dev version of 2.0.x. I plan on making a new release in early April.

🇺🇸United States joelsteidl

Solved my issue as well! I figured it out by turning on Claro and it worked when I clicked the Link icon in ckeditor5.

🇺🇸United States joelsteidl

I took a minute to try about JWT 6.x and didn't see any regressions. This module's usage is super minimal (only the encode method). Looking at the 6.x release notes, I didn't see any concerns around backwards compatibility issues with the encode method. https://github.com/firebase/php-jwt/releases/tag/v6.0.0

Feel free to take it for a spin and let me know if it works for you.

🇺🇸United States joelsteidl

I guess I'd be open to bumping to JWT 6.x, but I imagine you've seen that Zoom is deprecating JWT completely in June. https://www.drupal.org/project/zoomapi/issues/3283888 🌱 The JWT app type will be completely deprecated as of June 2023 Fixed

I'm currently working on a 3.x version that supports the Server-to-server app type (the replacement for JWT apps).

I'll do some testing with JWT 6.x and see if I notice any regressions.

🇺🇸United States joelsteidl

We are targeting the end of March 2023 for this to be available.

🇺🇸United States joelsteidl

This is a proof of concept (super rough) of how the client will need to be refactored.

https://gist.github.com/joelsteidl/fad398aab245b828a13a218e9640ad0a

Each request will need to include an access token as the Authorization header.

🇺🇸United States joelsteidl

We are still working on 3.x, but I went ahead and released a 2.1.0 version that supports Drupal 10.

🇺🇸United States joelsteidl

D10 supported added in 2.1.0.

🇺🇸United States joelsteidl

Thanks everyone. I went ahead and incorporated a lot of this work into a 2.1.0 release.

🇺🇸United States joelsteidl

@rodi88

I don't understand. Is there a code issue you are having?

🇺🇸United States joelsteidl

Applied the super minimal change and tagged a 2.0.x release.

Production build 0.69.0 2024