Fixing a potentially confusing example without the JSON key.
Sorry it took some time for you to find that.
The documentation example shows it with the JSON key.
https://www.drupal.org/docs/extending-drupal/contributed-modules/contrib... →
That's more Guzzle than anything. Please let me know if there is a better place to document this.
@mherchel
Have you tried the workaround mentioned in #29. I know it's not the long-term fix, but want to know more out of curiosity.
@socialnicheguru -- Did you already have the module installed when you applied the patch? If so, you may need to clear cache since the services were getting updated.
I completed the survey :)
joelsteidl → created an issue.
I feel like throwing exceptions by default could be a breaking change, so what if we just make it so throwing exceptions is optional. Would that still work for your needs?
joelsteidl → created an issue.
joelsteidl → created an issue.
joelsteidl → created an issue.
joelsteidl → created an issue.
Thanks @aaronbauman.
I made some headway today. If you wanted to review the MRs for
https://www.drupal.org/project/zoomapi/issues/3489251
📌
Deprecate Event Verification Token
Active
https://www.drupal.org/project/zoomapi/issues/3408495
🐛
Deprecated function: Creation of dynamic property Drupal\zoomapi\Plugin\ApiTools\Client::$id is deprecated
Active
I haven't looked at https://www.drupal.org/project/zoomapi/issues/3402268 🐛 Throw exceptions on errors Needs review so if you wanted to, that would be cool, but I also don't think I'd let that stop me from a stable release.
If you need 11.x support, that one might take a bit longer due to the reliance on Apitools module.
D11 is paused until we can get Apitools upgraded. It will be a bit heavier lift.
https://www.drupal.org/project/apitools/issues/3438140 📌 Automated Drupal 11 compatibility fixes for apitools Needs review
hi @boinkster,
Ignore my previous comment...potentially still relevant in some instances but this is really a dumb thing with the Zoom API.
After the meeting has passed, the meeting gets assigned a new UUID. This may not be that helpful in your situation if you are storing the original UUID.
<?php
// Meeting ID, not the UUID.
$meeting_id = '1234567890';
$client = \Drupal::service('zoomapi.client');
$endpoint = "past_meetings/$meeting_id/instances";
// This returned an array for me, but it contained UUIDs I could use for past meeting details.
$results = $client->get($endpoint);
// Now you can use your UUID to get what you need.
$uuid = 'YOUR_NEW_UUID_HERE';
$endpoint = "past_meetings/$uuid/participants";
$results = $client->get($endpoint);
Marking as closed won't fix for Zoom API since the config piece is part of Apitools, but please keep us updated on what folks are seeing.
On 10.3.10 I had no issues but the patch in apitools referenced above seems like the right approach.
The merge request removes the deprecated verification and writes an update hook to remove it from active config.
joelsteidl → created an issue.
The major issue here was trying to handle the use case where a user was coming from 2.x to 3.x and did not have apitools enabled . They couldn't get past the whitescreen of death.
I think the merge request handles that and the original issue reported.
I'd love any testing that folks can offer.
ahh...good to know!
Let me try to fix a couple issues in the queue and then get a stable out the door.
hi @boinkster,
Sorry you have having that issue. Add the end of the day, we are just using Guzzle for making the request. You could try something like this though....
function doubleEncodeMeetingUUID($meetingUUID) {
// Check if the meeting UUID begins with a '/' or contains '//'.
if (strpos($meetingUUID, '/') === 0 || strpos($meetingUUID, '//') !== false) {
// Double-encode the meeting UUID.
$meetingUUID = rawurlencode(rawurlencode($meetingUUID));
}
return $meetingUUID;
}
// Example usage:
$meetingUUID = '/example//uuid';
$encodedUUID = doubleEncodeMeetingUUID($meetingUUID);
echo $encodedUUID; // Output: %252Fexample%252F%252Fuuid
Completely untested, but maybe try a single or double rawurlencode before you concatenate your endpoint string. I'm happy to try and test further if that doesn't work.
Thanks for the patch @alexharries
Just noting that this solved the used for me as well. I agree with @erik.erskine wondering what purpose the added use statement serves.
@greg.1.anderson The patch in https://www.drupal.org/project/pantheon_advanced_page_cache/issues/3478153 🐛 Syntax error breaks all image uploading. Active fixed the issue for me. Thanks!
Just noting that the patch worked for me and will grab the new release shortly.
Interesting, I'm getting a similar error, but from a very different action.
Error: Undefined constant "ImageStyle" in pantheon_advanced_page_cache_file_update() (line 22 of /code/web/modules/contrib/pantheon_advanced_page_cache/pantheon_advanced_page_cache.module).
In my case, I have a Feeds module import running that is trying to create/update images and it is hitting the snag during image creation and make the feed import fail.
I have the Webp module enabled and will test if that may be the culprit.
This is linked on the module homepage too! https://www.drupal.org/docs/extending-drupal/contributed-modules/contrib... →
Thanks Jennifer!
joelsteidl → created an issue.
This made it into 2.0.1.
Overall the automated fixes are fine. I'm updating to not drop 9.x support as it still works fine.
2.x is no longer maintained.
The JWT app type will be deprecated. We recommend that you create Server-to-Server OAuth or OAuth apps to replace the functionality of a JWT app in your account. See the JWT app type migration guide for details.
On June 1, 2023, Developers will not be able to create new JWT app types.
On September 1, 2023, Zoom will disable JWT app type authorization. Contact Developer Support for details.
I am scheduled to be a speaker on Friday!
I am volunteering both days
Here!
joelsteidl → created an issue.
Thanks @SocialNicheGuru! So just confirming that this is a PHP 8.2 issue?
I need more information. Can you post a code example that was causing the deprecated function? Zoom API Module and APITools are not setting an $id
property. Are you setting one?
I just updated the mergevars description in the merge request. Happy to make that change elsewhere if it makes sense.
FYI, I'm on Drupal 10.1.x where I was having that issue.
joelsteidl → created an issue.
joelsteidl → created an issue.
joelsteidl → created an issue.
@BWilliams1992 is on to something with the javascript getting included twice. This module needs some love.
This refactor is headed in the right direction but wasn't working for me. https://www.drupal.org/project/gtranslate/issues/3346829 🐛 Refactor to use libraries and compatibility with Big Pipe Needs work
My sinful quick fix for now. If the block is found more than once I'm just doing a string replace to remove the javascript from getting added again. Be sure you pay attention to which widget you are using.
function hook_preprocess_block(&$variables) {
if ($variables['plugin_id'] == 'gtranslate_block') {
if (isset($variables['attributes']['id']) && $variables['attributes']['id'] != 'block-gtranslate') {
// Hack to remove the script tag from the gtranslate block if included more
// than once on the page. See https://www.drupal.org/project/gtranslate/issues/3396734.
$script = "<script>(function(){var js = document.createElement('script');js.setAttribute('src', 'https://cdn.gtranslate.net/widgets/latest/ln.js');js.setAttribute('data-gt-orig-url', '/');js.setAttribute('data-gt-orig-domain', 'tpa.lndo.site');document.body.appendChild(js);})();</script>";
$variables['content']['#gtranslate_html'] = str_replace($script, '', $variables['content']['#gtranslate_html']);
}
}
}
joelsteidl → made their first commit to this issue’s fork.
Hi @kathc. Sorry for the delayed response. You would need to implement your own slideshow solution (javascript, etc) as this is mainly taking care of the administrative side of things.
2.0.x Version is no longer viable because of Zoom API changes. Closing.
2.0.x Version is no longer viable because of Zoom API changes. Closing.
Committed to dev and will be part of 3.0.0-alpha3 soon.
Committed to dev and will be part of 3.0.0-alpha3 soon.
@lalustine Thanks for testing the patch.
Can you post your code for the failure?
@COBadger, did you happen to see https://www.drupal.org/project/views_filters_summary/issues/3345403 🐛 Remove link removes all filters Fixed
I'm wondering if you could test to see if it also resolves your issue.
Since this was such a minor change and it's been tested in production, I went ahead and merged. Available on the 8.x-1.x-dev branch.
I updated the merge request with some very minor tweaks.
joelsteidl → made their first commit to this issue’s fork.
I second this! Thank you!
https://git.drupalcode.org/project/simple_gse_search/-/merge_requests/2#... is working well on Drupal 10 too.
I tested https://git.drupalcode.org/project/entity_overlay/-/merge_requests/1#not... on Drupal 10 as well and it is working without issue.
joelsteidl → created an issue.
joelsteidl → made their first commit to this issue’s fork.
The changes are working well on Drupal 9 https://git.drupalcode.org/project/entity_overlay/-/merge_requests/1#not...
I will post back once tested on Drupal 10.
joelsteidl → made their first commit to this issue’s fork.
This has been tested and Drupal 9. https://git.drupalcode.org/project/simple_gse_search/-/merge_requests/2#...
I will report back once tested on Drupal 10.
joelsteidl → made their first commit to this issue’s fork.
I'm going to try the service provider route, at least until 3.1.0 and then possible deprecate that.
In the meantime, if anyone hits this error, I was able to enable apitools with drush even after upgrading with composer to 3.x.
Thanks @layalk! The patch solved the issue for me.
Please checkout the 3.0 alpha release https://www.drupal.org/project/stories →
This should be easier for folks to test without the complex composer workaround.
Thanks @attheshow and @keiserjb!
I tested this out on a pretty stock D10 site. It's a bit hard to test (with composer) since it modifies the info.yml file. This is how I went about it.
I followed the steps outlined here for this module. https://gorannikolovski.com/blog/how-to-upgrade-drupal-9-to-10#how-to-in...
In my composer.json, I specified that stories be installed from source so the Drupal.org packaging wouldn't be included.
"preferred-install": {
"drupal/stories": "source",
"*": "auto"
},
I added the patch:
"patches": {
"drupal/stories": {
"#3350002 - D10 Compatibility": "https://www.drupal.org/files/issues/2023-06-02/3350002-d10-compatibility-10.patch"
}
},
I'm going to go ahead and make an alpha 3.0.x release since one never existed.
Hi @SocialNicheGuru
It makes sense to me that you could leverage Zoom API module for handling the configuration of the API connection. What further collaboration do you see?
Please checkout the 3.0.x Alpha version. Open up issues if you have any.
This is working well with the 3.x version of Zoom API module. https://www.drupal.org/project/zoomapi/releases/3.0.x-dev →
You can checkout the annotation fields here https://git.drupalcode.org/project/zoomapi/-/blob/3.0.x/src/Plugin/ApiTo...
joelsteidl → created an issue.
joelsteidl → created an issue.
Thanks so much for following up!
Good feedback on apitools.
I'll look at getting a stable release up for that and and Zoom API 3.x. I might go straight for a stable sense the API changes on the Zoom side are required.
@pixiekat Thanks so much for testing things out. I'm curious if you've had any issues so far.
Hi Mark!
I think you are right...it looks to be as easy as updating the .info.yml file.
Shockingly, all the modules in composer.json have D10 compatible versions.
I do wonder if we should drop D8 support in the same commit.
If you have time to test the patch, please do. I imagine this will get committed pretty soon.
That should be the case. Guzzle will automatically format the JSON.
Let me know if that isn't the case.
We have a dev release up for 3.x!
composer require 'drupal/zoomapi:3.0.x-dev@dev'
Please take a look at the 2.x to 3.x documentation → and let us know if you have any immediate questions.
We'll continue to work towards a stable release closer to June.
joelsteidl → created an issue.
The 3.x version is just about ready for testing. https://git.drupalcode.org/project/zoomapi/-/tree/3.0.x
I will be working on documentation for converting from 2.x to 3.x.
Zoom has also made a lot of changes with Webhook validation that will become default in October 2023, so a lot of that is part of 3.x as well.
This change is available in the dev version of 2.0.x. I plan on making a new release in early April.
Solved my issue as well! I figured it out by turning on Claro and it worked when I clicked the Link icon in ckeditor5.