AssertionError: assert($key_type instanceof KeyPluginBase) in assert() (line 164 of samlauth/src/Form/SamlauthSamlConfigureForm.php)

Patch file in case it's useful to anyone :)

/A

+++ b/src/Form/SamlauthSamlConfigureForm.php
+use Drupal\key\Plugin\KeyPluginBase;

This bit looks good. I had the same problem and came to the same fix.

-      'sp_name_id_format',
+      // DON'T SAVE sp_name_id_format HERE! If it was set to "Custom", this
+      // field will have a value of * and will overwrite the code which
+      // correctly sets the value in src/Form/SamlauthConfigureTrait.php
+      // in setNameID().
+//      'sp_name_id_format',

This bit looks unrelated, perhaps a separate issue?

Thanks for the patch @alexharries

Just noting that this solved the used for me as well. I agree with @erik.erskine wondering what purpose the added use statement serves.

(Oops, forgot names in commit message. But credited while fixing.)

Thanks @alesharries. Again, dumb mistake when refactoring the form.

The unrelated bit is from 🐛 Bug and confusing behaviour when trying to set a custom NameID format which is already known to the module Active and has been fixed in there / should have been pushed to that PR, instead of this one.

roderik → closed merge request !23