Deprecated function: Creation of dynamic property Drupal\zoomapi\Plugin\ApiTools\Client::$id is deprecated

abhishek_gupta1 → made their first commit to this issue’s fork.

@dewalt, I have fixed the issue. please kindly review the MR

I need more information. Can you post a code example that was causing the deprecated function? Zoom API Module and APITools are not setting an $id property. Are you setting one?

I installed and enabled and have not setup the zoomapi module.

Here is what I get:

ttps://mysite/admin/commerce/config||1||Deprecated function: Creation of dynamic property Drupal\zoomapi\Plugin\ApiTools\Client::$id is deprecated in Drupal\Component\DependencyInjection\Container->createService() (line 285 of drupal10.2.4/html/core/lib/Drupal/Component/DependencyInjection/Container.php) #0 drupal10.2.4/html/core/includes/bootstrap.inc(164): _drupal_error_handler_real()
Mar 7 14:01:17 mysite drupal: #1 drupal10.2.4/html/core/lib/Drupal/Component/DependencyInjection/Container.php(285): _drupal_error_handler()
Mar 7 14:01:17 mysite drupal: #2 drupal10.2.4/html/core/lib/Drupal/Component/DependencyInjection/Container.php(177): Drupal\Component\DependencyInjection\Container->createService()
Mar 7 14:01:17 mysite drupal: #3 drupal10.2.4/html/core/lib/Drupal.php(197): Drupal\Component\DependencyInjection\Container->get()
Mar 7 14:01:17 mysite drupal: #4 drupal10.2.4/html/modules/contrib/zoomapi/zoomapi.install(17): Drupal::service()
Mar 7 14:01:17 mysite drupal: #5 [internal function]: zoomapi_requirements()
Mar 7 14:01:17 mysite drupal: #6 drupal10.2.4/html/core/lib/Drupal/Core/Extension/ModuleHandler.php(409): call_user_func_array()
Mar 7 14:01:17 mysite drupal: #7 drupal10.2.4/html/core/lib/Drupal/Core/Extension/ModuleHandler.php(388): Drupal\Core\Extension\ModuleHandler->Drupal\Core\Extension\{closure}()
Mar 7 14:01:17 mysite drupal: #8 drupal10.2.4/html/core/lib/Drupal/Core/Extension/ModuleHandler.php(408): Drupal\Core\Extension\ModuleHandler->invokeAllWith()
Mar 7 14:01:17 mysite drupal: #9 drupal10.2.4/html/core/modules/system/src/SystemManager.php(109): Drupal\Core\Extension\ModuleHandler->invokeAll()
Mar 7 14:01:17 mysite drupal: #10 drupal10.2.4/html/core/modules/system/src/SystemManager.php(93): Drupal\system\SystemManager->listRequirements()
Mar 7 14:01:17 mysite drupal: #11 drupal10.2.4/html/core/modules/system/src/Controller/SystemController.php(123): Drupal\system\SystemManager->checkRequirements()
Mar 7 14:01:17 mysite drupal: #12 [internal function]: Drupal\system\Controller\SystemController->overview()
Mar 7 14:01:17 mysite drupal: #13 drupal10.2.4/html/core/lib/Drupal/Core/EventSubscriber/EarlyRenderingControllerWrapperSubscriber.php(123): call_user_func_array()
Mar 7 14:01:17 mysite drupal: #14 drupal10.2.4/html/core/lib/Drupal/Core/Render/Renderer.php(627): Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}()
Mar 7 14:01:17 mysite drupal: #15 drupal10.2.4/html/core/lib/Drupal/Core/EventSubscriber/EarlyRenderingControllerWrapperSubscriber.php(121): Drupal\Core\Render\Renderer->executeInRenderContext()
Mar 7 14:01:17 mysite drupal: #16 drupal10.2.4/html/core/lib/Drupal/Core/EventSubscriber/EarlyRenderingControllerWrapperSubscriber.php(97): Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext()
Mar 7 14:01:17 mysite drupal: #17 drupal10.2.4/vendor/symfony/http-kernel/HttpKernel.php(181): Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}()
Mar 7 14:01:17 mysite drupal: #18 drupal10.2.4/vendor/symfony/http-kernel/HttpKernel.php(76): Symfony\Component\HttpKernel\HttpKernel->handleRaw()
Mar 7 14:01:17 mysite drupal: #19 drupal10.2.4/html/modules/contrib/simple_oauth/src/HttpMiddleware/BasicAuthSwap.php(54): Symfony\Component\HttpKernel\HttpKernel->handle()
Mar 7 14:01:17 mysite drupal: #20 drupal10.2.4/html/modules/contrib/bat_api/src/StackMiddleware/BatApiMiddleware.php(39): Drupal\simple_oauth\HttpMiddleware\BasicAuthSwap->handle()
Mar 7 14:01:17 mysite drupal: #21 drupal10.2.4/html/core/lib/Drupal/Core/StackMiddleware/Session.php(58): Drupal\bat_api\StackMiddleware\BatApiMiddleware->handle()
Mar 7 14:01:17 mysite drupal: #22 drupal10.2.4/html/core/lib/Drupal/Core/StackMiddleware/KernelPreHandle.php(48): Drupal\Core\StackMiddleware\Session->handle()
Mar 7 14:01:17 mysite drupal: #23 drupal10.2.4/html/core/lib/Drupal/Core/StackMiddleware/ContentLength.php(28): Drupal\Core\StackMiddleware\KernelPreHandle->handle()
Mar 7 14:01:17 mysite drupal: #24 drupal10.2.4/html/core/modules/big_pipe/src/StackMiddleware/ContentLength.php(32): Drupal\Core\StackMiddleware\ContentLength->handle()
Mar 7 14:01:17 mysite drupal: #25 drupal10.2.4/html/core/modules/page_cache/src/StackMiddleware/PageCache.php(106): Drupal\big_pipe\StackMiddleware\ContentLength->handle()
Mar 7 14:01:17 mysite drupal: #26 drupal10.2.4/html/core/modules/page_cache/src/StackMiddleware/PageCache.php(85): Drupal\page_cache\StackMiddleware\PageCache->pass()
Mar 7 14:01:17 mysite drupal: #27 drupal10.2.4/html/modules/contrib/services/src/StackMiddleware/FormatSetter.php(45): Drupal\page_cache\StackMiddleware\PageCache->handle()
Mar 7 14:01:17 mysite drupal: #28 drupal10.2.4/html/modules/contrib/webform_product/src/RedirectMiddleware.php(43): Drupal\services\StackMiddleware\FormatSetter->handle()
Mar 7 14:01:17 mysite drupal: #29 drupal10.2.4/html/core/lib/Drupal/Core/StackMiddleware/ReverseProxyMiddleware.php(48): Drupal\webform_product\RedirectMiddleware->handle()
Mar 7 14:01:17 mysite drupal: #30 drupal10.2.4/html/core/lib/Drupal/Core/StackMiddleware/NegotiationMiddleware.php(51): Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle()
Mar 7 14:01:17 mysite drupal: #31 drupal10.2.4/html/core/lib/Drupal/Core/StackMiddleware/AjaxPageState.php(36): Drupal\Core\StackMiddleware\NegotiationMiddleware->handle()
Mar 7 14:01:17 mysite drupal: #32 drupal10.2.4/html/core/lib/Drupal/Core/StackMiddleware/StackedHttpKernel.php(51): Drupal\Core\StackMiddleware\AjaxPageState->handle()
Mar 7 14:01:17 mysite drupal: #33 drupal10.2.4/html/core/lib/Drupal/Core/DrupalKernel.php(714): Drupal\Core\StackMiddleware\StackedHttpKernel->handle()
Mar 7 14:01:17 mysite drupal: #34 drupal10.2.4/html/index.php(19): Drupal\Core\DrupalKernel->handle()
Mar 7 14:01:17 mysite drupal: #35 {main}.

The MR yields another error:

/admin/reports/status|https://onebayview.com/|1||Error: Cannot access protected property Drupal\zoomapi\Plugin\ApiTools\Client::$id in Drupal\Component\DependencyInjection\Container->createService() (line 285 of /drupal10.2.4/html/core/lib/Drupal/Component/DependencyInjection/Container.php).

Thanks @SocialNicheGuru! So just confirming that this is a PHP 8.2 issue?

@joelsteidl →

Hi, The deprecation error is invoked because the id is passed to the set property in the Service alter function.

 public function alter(ContainerBuilder $container) {
    if ($container->hasDefinition('apitools.client_base')) {
      $definition = new ChildDefinition('apitools.client_base');
      $definition->setClass('Drupal\zoomapi\Plugin\ApiTools\Client')
        ->addArgument('zoomapi')
        ->setProperty('id', 'zoomapi.client');
      // Add the definition to the container.
      $container->setDefinition('zoomapi.client', $definition);
    }
  }

The major issue here was trying to handle the use case where a user was coming from 2.x to 3.x and did not have apitools enabled . They couldn't get past the whitescreen of death.

I think the merge request handles that and the original issue reported.

I'd love any testing that folks can offer.

Tested the patch locally with version: '3.0.0-alpha3', seems to get rid of the error

With the patch I now get a different error

Fatal error: Uncaught ArgumentCountError: Too few arguments to function Drupal\Core\StreamWrapper\StreamWrapperManager::__construct(), 0 passed and exactly 1 expected in drupal-10.3.x/html/core/lib/Drupal/Core/StreamWrapper/StreamWrapperManager.php:21
Stack trace:
#0 [internal function]: Drupal\Core\StreamWrapper\StreamWrapperManager->__construct()
#1 drupal-10.3.x/vendor/symfony/dependency-injection/ContainerBuilder.php(1140): ReflectionClass->newInstanceArgs()
#2 drupal-10.3.x/vendor/symfony/dependency-injection/ContainerBuilder.php(586): Symfony\Component\DependencyInjection\ContainerBuilder->createService()
#3 drupal-10.3.x/vendor/symfony/dependency-injection/ContainerBuilder.php(1258): Symfony\Component\DependencyInjection\ContainerBuilder->doGet()
#4 drupal-10.3.x/vendor/symfony/dependency-injection/ContainerBuilder.php(1210): S
ymfony\Component\DependencyInjection\ContainerBuilder->doResolveServices()
#5 drupal-10.3.x/vendor/symfony/dependency-injection/ContainerBuilder.php(1110): Symfony\Component\DependencyInjection\ContainerBuilder->doResolveServices()
#6 drupal-10.3.x/vendor/symfony/dependency-injection/ContainerBuilder.php(586): Symfony\Component\DependencyInjection\ContainerBuilder->createService()
#7 drupal-10.3.x/vendor/symfony/dependency-injection/ContainerBuilder.php(1258): Symfony\Component\DependencyInjection\ContainerBuilder->doGet()
#8 drupal-10.3.x/vendor/symfony/dependency-injection/ContainerBuilder.php(1210): Symfony\Component\DependencyInjection\ContainerBuilder->doResolveServices()
#9 drupal-10.3.x/vendor/symfony/dependency-injection/ContainerBuilder.php(1110): Symfony\Component\DependencyInjection\ContainerBuilder->doResolveServices()
#10 drupal-10.3.x/vendor/symfony/dependency-injection/ContainerBuilder.php(586): Symfony\Component\DependencyInjection\ContainerBuilder->createService()
#11 drupal-10.3.x/vendor/symfony/dependency-injection/ContainerBuilder.php(531): Symfony\Component\DependencyInjection\ContainerBuilder->doGet()
#12 drupal-10.3.x/html/core/lib/Drupal/Core/Cache/CacheFactory.php(110): Symfony\Component\DependencyInjection\ContainerBuilder->get()
#13 drupal-10.3.x/vendor/symfony/dependency-injection/ContainerBuilder.php(1121): Drupal\Core\Cache\CacheFactory->get()
#14 drupal-10.3.x/vendor/symfony/dependency-injection/ContainerBuilder.php(586): Symfony\Component\DependencyInjection\ContainerBuilder->createService()
#15 drupal-10.3.x/vendor/symfony/dependency-injection/ContainerBuilder.php(1258): Symfony\Component\DependencyInjection\ContainerBuilder->doGet()
#16 drupal-10.3.x/vendor/symfony/dependency-injection/ContainerBuilder.php(1210): Symfony\Component\DependencyInjection\ContainerBuilder->doResolveServices()
#17 drupal-10.3.x/vendor/symfony/dependency-injection/ContainerBuilder.php(1110): Symfony\Component\DependencyInjection\ContainerBuilder->doResolveServices()
#18 drupal-10.3.x/vendor/symfony/dependency-injection/ContainerBuilder.php(586): Symfony\Component\DependencyInjection\ContainerBuilder->createService()
#19 drupal-10.3.x/vendor/symfony/dependency-injection/ContainerBuilder.php(531): Symfony\Component\DependencyInjection\ContainerBuilder->doGet()
#20 drupal-10.3.x/html/modules/contrib/zoomapi/src/ZoomapiServiceProvider.php(17): Symfony\Component\DependencyInjection\ContainerBuilder->get()
#21 drupal-10.3.x/html/core/lib/Drupal/Core/DependencyInjection/Compiler/ModifyServiceDefinitionsPass.php(30): Drupal\zoomapi\ZoomapiServiceProvider->alter()
#22 drupal-10.3.x/vendor/symfony/dependency-injection/Compiler/Compiler.php(80): Drupal\Core\DependencyInjection\Compiler\ModifyServiceDefinitionsPass->process()
#23 /var/aegir/platforms/d
rupal/10/distro/1-dev/custom/dev4-cci-social-13.x-drupal-10.3.x/vendor/symfony/dependency-injection/ContainerBuilder.php(767): Symfony\Component\DependencyInjection\Compiler\Compiler->compile()
#24 drupal-10.3.x/html/core/lib/Drupal/Core/DrupalKernel.php(1447): Symfony\Component\DependencyInjection\ContainerBuilder->compile()
#25 drupal-10.3.x/html/core/lib/Drupal/Core/DrupalKernel.php(971): Drupal\Core\DrupalKernel->compileContainer()
#26 drupal-10.3.x/html/core/lib/Drupal/Core/DrupalKernel.php(515): Drupal\Core\DrupalKernel->initializeContainer()
#27 drupal-10.3.x/html/core/includes/utility.inc(34): Drupal\Core\DrupalKernel->boot()
#28 /usr/local/share/drush/commands/core/cache.drush.inc(302): drupal_rebuild()
#29 /usr/local/share/drush/includes/command.inc(422): drush_cache_rebuild()
#30 /usr/local/share/drush/includes/command.inc(231): _drush_invoke_hooks()
#31 /usr/local/share/drush/includes/command.inc(199): drush_command()
#32 /usr/local/share/drush/lib/Drush/Boot/BaseBoot.php(67): drush_dispatch()
#33 /usr/local/share/drush/includes/preflight.inc(67): Drush\Boot\BaseBoot->bootstrap_and_dispatch()
#34 /usr/local/share/drush/drush.php(12): drush_main()
#35 {main}

@socialnicheguru -- Did you already have the module installed when you applied the patch? If so, you may need to clear cache since the services were getting updated.