Add better support for linking to anchors

Reroll without changing anything

#22/27 works with 8.x-5.x
#26 works with 6.0.x

What about passing just query and fragment. This keeps the plugin interface much cleaner.

The last submitted patch, 29: 3022261-29.patch, failed testing. View results →

Patch does not apply anymore

Please review #36

patch does not apply

Rerolled patch #36, please review it.

Thanks!

Rerolled the patch for latest changes.

+1 - would be great to get this feature in a stable release :-)

I've taken the patch in #41 and put it into a merge request to demonstrate passing test coverage against the latest development in Linkit.

Data attributes are currently removed again when adding a URL fragment manually. It seems that this is caused by https://www.drupal.org/project/linkit/issues/3443845 🐛 When [Enter] key is used to replace a link, the previous link's attributes are not removed Fixed . Commenting out 3 lines in /js/ckeditor5_plugins/linkit/src/index.js and rebuilding /js/build/linkit.js fixes the issue:

const linkit = editor.plugins.get('Linkit');
linkFormView.urlInputView.fieldView.element.addEventListener('input', function (evt) {
  //linkit.set('entityType', null);
  //linkit.set('entityUuid', null);
  //linkit.set('entitySubstitution', null);
});

Steps to reproduce

1. Create a link by selecting a node from autocomplete: the data attributes are added correctly.
2. Edit the link by adding a URL fragment manually and hitting the enter key: the data attributes are removed.
3. After commenting out the above mentioned code and rebuilding the javascript file, the data attributes remain after step 2