🇨🇭Switzerland @boromino

Data attributes are currently removed again when adding a URL fragment manually. It seems that this is caused by https://www.drupal.org/project/linkit/issues/3443845 🐛 When [Enter] key is used to replace a link, the previous link's attributes are not removed Fixed . Commenting out 3 lines in /js/ckeditor5_plugins/linkit/src/index.js and rebuilding /js/build/linkit.js fixes the issue:

const linkit = editor.plugins.get('Linkit');
linkFormView.urlInputView.fieldView.element.addEventListener('input', function (evt) {
  //linkit.set('entityType', null);
  //linkit.set('entityUuid', null);
  //linkit.set('entitySubstitution', null);
});

Steps to reproduce

1. Create a link by selecting a node from autocomplete: the data attributes are added correctly.
2. Edit the link by adding a URL fragment manually and hitting the enter key: the data attributes are removed.
3. After commenting out the above mentioned code and rebuilding the javascript file, the data attributes remain after step 2

Completely agree with splitting off a ckeditor_abbreviation-5.0.x branch to add D11 support and drop D9 support.

Thanks for the patch. Fixed and created new release.

Granted, thanks for supporting the module.

boromino → created an issue.

boromino → made their first commit to this issue’s fork.

There are 2 more instances of unserialize, I guess they should be changed too?

No, because there config is loaded which is actually serialized.

In the 1.x branch we probably also need to define that version 2 of content_access is required, but that's only needed for the backport then

Version 2 of content access is already required in 1.x branch (my task description may be confusing in so far).

That fixes the issue, but maybe it would be better to use content_access_get_per_node_settings() and content_access_save_per_node_settings() respectively.

boromino → created an issue.

According to HTML specification, the abbr tag may be used with or without the title attribute. In version 2 there were 2 form inputs, and it was possible to only remove the title attribute. Your patch doesn't seem to allow for abbr tag without title attribute.

I will look further into it as soon as possible. Feel free to provide another patch, and I will review it as soon as I can.

boromino → created an issue.

It is related to that core issue. However, the patch does not fix it, because the entity is the default revision when \Drupal\eca_workflow\HookHandler::transition() is run.

\Drupal\content_moderation\moderationInformation::getOriginalState() isn't appropriate, either, because it returns the initial state for new entities, which would prevent triggering the event.

Therefore, I have provided a patch. It may become obsolete, once the core issue is fixed.

boromino → created an issue.

Version 4 is now compatible with CKEditor 4/5 and Drupal 9.5/10.

Overlooked one line to revert.

As described in https://www.drupal.org/project/drupal/issues/3403785 🐛 Drag’n’drop not disabled when term has multiple parents Needs review , the committed solution does not hide the drag'n'drop icons nor the Show row weights link if there is a term with multiple parents. Therefore, I'm attaching a patch that fixes this for 9.5.x.

boromino → created an issue.

boromino → created an issue.

Granted, thanks for supporting the module.

boromino → created an issue.

Thanks for the explanation, that helped me to find the error. My mistake was that I had left "Data to compare with" empty instead of adding the original value there, too.

boromino → created an issue.

jurgenhaas → credited boromino → .

That makes sense, I have updated the merge request accordingly.

boromino → created an issue.

jurgenhaas → credited boromino → .

boromino → created an issue.

boromino → created an issue.

A form error is triggered if entity type is required, but none is selected. However, I can not get the corresponding form field to be highlighted. #array_parents in \Drupal\Core\Form\SubFormState::setErrorByName() does not seem to match with the entity type form field name.

Added #states to form elements on entity loader service and entity load action.

Provide some settings so that users can switch between the property panels of either Drupal or bpmn_io

Why not just implement it as a separate modeler plugin?

#439 works on 8.8.6, no duplicates with views data export.