CKEditor 5: Toolbar button not translated

Once this is fixed, it would be nice to tag a new release. We just migrated from CKEditor 4 to version 5, and this makes this button harder to use for German users.

aaron.ferris → made their first commit to this issue’s fork.

Ive had a go at this, the diff for the build is a bit odd though, what am I doing wrong?

1. npm install
2. npm run build

?

I think @boromino is more knowledgeable than myself about whether this is the correct solution (and whether the JS got built correctly).

The code looks like Drupal Core's MissingAlternativeTextView custom CKEditor plugin, and I know from experience that Drupal.t() is the correct way to use Drupal's translation system in Drupal-JavaScript → , so it seems good to me.

Thanks for the patch. Fixed and created new release.

Hello @boromino sorry to be a pain, but would appreciate a contribution credit for this please!

You were credited in the commit message; but I've credited you in the issue node as well! Thanks very much!

Thanks @mparker17 :)

Automatically closed - issue fixed for 2 weeks with no activity.

mparker17 → closed merge request !8