Allow for the abbr-tag to be removed while editing

Created on 6 November 2023, about 1 year ago
Updated 15 March 2024, 8 months ago

Problem/Motivation

In the older version (2) you could remove the abbr-tag by removing the title and description while editing and then saving.

Proposed resolution

Perhaps a little trashcan-icon next to the save check-mark/cancel X buttons?

Remaining tasks

  • decide on which solution
  • develop it :)

User interface changes

A new button to delete the abbr-tag.

API changes

-

Data model changes

-

✨ Feature request
Status

Fixed

Version

4.0

Component

User interface

Created by

πŸ‡³πŸ‡±Netherlands spadxiii

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @spadxiii
  • Status changed to Needs review 10 months ago
  • πŸ‡ΊπŸ‡¦Ukraine sickness29

    Prepared a patch that removes abbr tag when empty title is applied, i.e. like in version 2.

  • Status changed to Needs work 9 months ago
  • πŸ‡¨πŸ‡­Switzerland boromino

    According to HTML specification, the abbr tag may be used with or without the title attribute. In version 2 there were 2 form inputs, and it was possible to only remove the title attribute. Your patch doesn't seem to allow for abbr tag without title attribute.

    I will look further into it as soon as possible. Feel free to provide another patch, and I will review it as soon as I can.

  • Status changed to Needs review 9 months ago
  • πŸ‡ΊπŸ‡¦Ukraine sickness29

    Hi @boromino,
    I see. I have changed implementation by providing new Remove button and added command to remove abbr tag.
    Now it's possible to add empty title and also possible to remove abbreviation altogether without need to remove text.

  • Status changed to Fixed 9 months ago
  • πŸ‡¨πŸ‡­Switzerland boromino
  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024