- Issue created by @project update bot
This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request is also openend and updated.
It is important that any automated tests available are run and that you manually test the changes.
Drupal 11 Compatibility
According to the Upgrade Status module → these changes make this module compatible with Drupal 11! 🎉
Therefore these changes update theinfo.yml
file for Drupal 11 compatibility.Leaving this issue open, even after committing the current patch, will allow the Project Update Bot → to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.
Debug info
Bot run #11-120835This patch was created using these packages:
- drupal/upgrade_status: 4.1.0
- mglaman/phpstan-drupal: 1.2.7
- palantirnet/drupal-rector: 0.20.1
- Merge request !4Issue #3429173: Automated Drupal 11 compatibility fixes for ckeditor_abbreviation → (Closed) created by project update bot
- Status changed to RTBC
8 months ago 1:36am 26 March 2024 - Merge request !6Issue #3429173: Automated Drupal 11 compatibility fixes for ckeditor_abbreviation → (Closed) created by mparker17
- 🇨🇦Canada mparker17 UTC-4
Created my own merge request to upgrade the
4.0.x
branch: previously this filed against the 3.0.0 branch and patched that way too.I have run manual tests on a D11 site with the changes in this merge request, and it works well.
- 🇨🇦Canada mparker17 UTC-4
mparker17 → changed the visibility of the branch project-update-bot-only to hidden.
- Status changed to Postponed
8 months ago 4:28pm 2 April 2024 - 🇨🇦Canada mparker17 UTC-4
Hmm...
- If I leave the dependency on drupal/ckeditor, then the D11 tests won't run; but that's important for the future.
- If I drop the dependency on drupal/ckeditor, then the D10 and D11 phpstan will fail because they can't find the
</li> <li>\Drupal\ckeditor_abbreviation\Plugin\CKEditorPlugin\AbbreviationCKEditorButton
class
- If ignore the PHPStan failures with a
phpstan-baseline.neon
, then phpstan on D9 will fail because it's expecting to get errors and won't get them.
I daresay the best solution here would be to split off a ckeditor_abbreviation-5.0.x branch to add D11 support and drop D9 support. (Aside: I'm fine with supporting two stable branches, as long as we have automated tests (i.e.: ✨ Add automated regression tests Needs work ).
So I'm going to mark this issue as postponed for now. Once the automated tests are merged, then we can re-evaluate.
- 🇨🇭Switzerland boromino
Completely agree with splitting off a ckeditor_abbreviation-5.0.x branch to add D11 support and drop D9 support.
- 🇦🇺Australia acbramley
Do we need to wait for a stable 4.x in order to support D11 on another branch? It would be good to unblock sites using this module with at least a 5.x alpha?
- 🇨🇦Canada mparker17 UTC-4
@acbramley, i plan to make a new 4.0.0-alpha release this week with d11 compatibility; i have just been really busy since i committed the d11 fix!
Thanks for your understanding and patience!
- Status changed to Fixed
4 months ago 1:44pm 2 August 2024 - 🇨🇦Canada mparker17 UTC-4
I apologize for the delay! I've created ckeditor_abbreviation-4.0.0-alpha5 → , which adds D11 support.
Automatically closed - issue fixed for 2 weeks with no activity.