- Issue created by @boromino
- Merge request !1Resolve #3421347 "Typeerror in revokeaccessupdatesettings" → (Closed) created by boromino
- Merge request !2Fix TypeError in GrantAccess content access settings database query result conversion. → (Merged) created by boromino
- Issue was unassigned.
- Status changed to Needs review
9 months ago 11:15am 14 February 2024 - 🇨🇭Switzerland boromino
That fixes the issue, but maybe it would be better to use content_access_get_per_node_settings() and content_access_save_per_node_settings() respectively.
- Status changed to Needs work
9 months ago 1:58pm 14 February 2024 - 🇩🇪Germany jurgenhaas Gottmadingen
Thanks @boromino for this report. Yes, I wanted to use that other method originally as well but ran into issues that I couldn't resolve.
Your MR looks good as a starting point, but I think there are a couple more things that also need to be done:
- There are 2 more instances of
unserialize
, I guess they should be changed too? - In the 1.x branch we probably also need to define that version 2 of content_access is required, but that's only needed for the backport then
- There are 2 more instances of
- Status changed to Needs review
9 months ago 5:14pm 14 February 2024 - 🇨🇭Switzerland boromino
There are 2 more instances of unserialize, I guess they should be changed too?
No, because there config is loaded which is actually serialized.
In the 1.x branch we probably also need to define that version 2 of content_access is required, but that's only needed for the backport then
Version 2 of content access is already required in 1.x branch (my task description may be confusing in so far).
-
jurgenhaas →
committed 7ec5f6f7 on 2.0.x authored by
boromino →
Issue #3421347: TypeError in RevokeAccess::updateSettings
-
jurgenhaas →
committed 7ec5f6f7 on 2.0.x authored by
boromino →
- Status changed to RTBC
9 months ago 8:01am 15 February 2024 - 🇩🇪Germany jurgenhaas Gottmadingen
OK, got it. I've merged this into 2.0.x and will now backport to 1.0.x and publish a new release.
-
jurgenhaas →
committed ad3086bb on 1.0.x authored by
boromino →
Issue #3421347: TypeError in RevokeAccess::updateSettings
-
jurgenhaas →
committed ad3086bb on 1.0.x authored by
boromino →
-
jurgenhaas →
committed a6086fa4 on 1.0.x
Issue #3421347: TypeError in RevokeAccess::updateSettings
-
jurgenhaas →
committed a6086fa4 on 1.0.x
- Status changed to Fixed
9 months ago 8:10am 15 February 2024 - 🇩🇪Germany jurgenhaas Gottmadingen
Version 2 of content access is already required in 1.x branch
Yes, in the composer.json but not in the info file. I've added it there now too and published release 1.0.2
Automatically closed - issue fixed for 2 weeks with no activity.