Account created on 12 September 2005, over 18 years ago
  • Developer & Architect at SWISΒ 
#

Merge Requests

Recent comments

πŸ‡³πŸ‡±Netherlands casey

What about changing the return type/hint of EntityInterface::id() and all other ID parameters//returns to ?string and dropping int altogether as possible return type.

IDs are used to uniquely identify entities and not to do calculations with or anything.
Dropping int as will simplify the interface and makes it easier to enforce strict typing ( https://www.drupal.org/project/drupal/issues/3050720#comment-13562649 🌱 [Meta] Implement strict typing in existing code Active )
It will still be possible to do things like auto increment (no issue at all when handled by the DB) and finding the next available (numeric) ID.

I think almost all existing code will continue to work; as already stated, the type of ID variables are already inconsistent.

πŸ‡³πŸ‡±Netherlands casey

casey β†’ made their first commit to this issue’s fork.

πŸ‡³πŸ‡±Netherlands casey

It looks like this issue has been fixed in πŸ› ajax_page_state leaks through request in Views Ajax Needs work

πŸ‡³πŸ‡±Netherlands casey

In development environments the api key is typically not provided. When the api key is missing currently every drush call triggers at least one " [error] OhDear site id is missing! Fix it ..."

πŸ‡³πŸ‡±Netherlands casey

Static patch file of MR up until #4 for use with composer-patches

πŸ‡³πŸ‡±Netherlands casey

To be able to update the change time during syncing the EntityChangedConstraintValidator must also be updated

πŸ‡³πŸ‡±Netherlands casey

Previous patch used the wrong variable in constructor

πŸ‡³πŸ‡±Netherlands casey

Maybe we should also check visibility rules? Something like this might work.

πŸ‡³πŸ‡±Netherlands casey

I think I agree with Berdir that the right solution is to trigger an exception.

πŸ‡³πŸ‡±Netherlands casey

Something like this would work.

To lock a row, it should not have a draggable class and its weight should be disabled. Also, this patch only works for (not select) inputs as weight.

πŸ‡³πŸ‡±Netherlands casey

This patch only fixes ImageStyleDownloadController and is only to be used in combination with patch #5 #3309534-6: Accessing private file with .jpg, .jpeg, .png extension returns WEBP image β†’ .

πŸ‡³πŸ‡±Netherlands casey

Actually, why is it even allowed to request/generate a webp when a specific (not a image-style derivative) file is being requested?

This patch simply removes the FileDownloadController replacement.

πŸ‡³πŸ‡±Netherlands casey

It would be even better to first check if a webp is being requested, before trying to validate if the requested uri is an image.

πŸ‡³πŸ‡±Netherlands casey

Here's a patch that removes the jquery dependency from better_exposed_filters/general and better_exposed_filters/auto_submit

πŸ‡³πŸ‡±Netherlands casey

Just run into this issue as well. What about only checking the query arguments from data-drupal-link-query and only skip if any of those donΒ΄t match the current query, while ignoring any additional query arguments from the current query.

πŸ‡³πŸ‡±Netherlands casey

What about passing just query and fragment. This keeps the plugin interface much cleaner.

πŸ‡³πŸ‡±Netherlands casey

This patch also allows the use of html tags in the more link text

πŸ‡³πŸ‡±Netherlands casey

Here's a patch we've been using in a project since D8 to support argument tokens.

πŸ‡³πŸ‡±Netherlands casey

MR as patch file to be able to use it via composer-patches

πŸ‡³πŸ‡±Netherlands casey

*For 50% written by ChatGPT :D

Production build https://api.contrib.social 0.61.6-2-g546bc20