- 🇺🇸United States scottsawyer Atlanta
Just wanted to note that this patch no longer applies to 1.7.0. I am no longer experiencing a condition that causes the error, so removing the patch, and crossing fingers...
- Status changed to Needs work
about 1 year ago 6:16am 15 March 2024 - 🇮🇳India prem suthar Ahemdabad- Gujrat , Jodhpur - Rajsthan
# 4 patch is Failed To Apply on the latest Code .
Checking patch src/Cache/PhpRedis.php... Checking patch src/Cache/RedisCacheTagsChecksum.php... error: while searching for: // We want to differentiate between PhpRedis and Redis clients. if ($this->clientType === 'PhpRedis') { $multi = $this->client->multi(); foreach ($keys as $key) { $multi->incr($key); } error: patch failed: src/Cache/RedisCacheTagsChecksum.php:58 error: src/Cache/RedisCacheTagsChecksum.php: patch does not apply Checking patch src/Lock/PhpRedis.php... Checking patch src/Queue/ReliablePhpRedis.php...
- 🇮🇳India prem suthar Ahemdabad- Gujrat , Jodhpur - Rajsthan
Updated The Patch as per latest code.
- Status changed to Needs review
about 1 year ago 6:26am 15 March 2024 - 🇧🇬Bulgaria alexrayu
Sadly patch from #8 did not apply for me upgrading to 1.8.0
Attaching the patch for 1.8.0. - 🇳🇱Netherlands casey
https://github.com/phpredis/phpredis?tab=readme-ov-file#multi-exec-discard
Redis::MULTI or Redis::PIPELINE. Defaults to Redis::MULTI. A Redis::MULTI block of commands runs as a single transaction; a Redis::PIPELINE block is simply transmitted faster to the server, but without any guarantee of atomicity.
I guess we want to keep atomicity. Instead of switching to Redis::PIPELINE, a check should be added on the return value of the multi() call.
- Merge request !483143396-error-call-to : Added the MR From the Patch. → (Open) created by prem suthar
- 🇮🇳India prem suthar Ahemdabad- Gujrat , Jodhpur - Rajsthan
@berdir Added the Mr From the #10. Please Review
- 🇨🇭Switzerland berdir Switzerland
Tests are failing with relay because that constant then doesn't exist.
- 🇫🇷France MacSim
I also met this error on a prod instance where redis was hosted on another virtual machine and running in protected mode.
$ drush cr PHP Fatal error: Uncaught Error: Call to a member function hMset() on bool in /var/www/html/web/modules/contrib/redis/src/Cache/PhpRedis.php:97 $ nc {redis_ip} 6379 -DENIED Redis is running in protected mode because protected mode is enabled and no password is set for the default user. In this mode connections are only accepted from the loopback interface. If you want to connect from external computers to Redis you may adopt one of the following solutions: 1) Just disable protected mode sending the command 'CONFIG SET protected-mode no' from the loopback interface by connecting to Redis from the same host the server is running, however MAKE SURE Redis is not publicly accessible from internet if you do so. Use CONFIG REWRITE to make this change permanent. 2) Alternatively you can just disable the protected mode by editing the Redis configuration file, and setting the protected mode option to 'no', and then restarting the server. 3) If you started the server manually just for testing, restart it with the '--protected-mode no' option. 4) Set up an authentication password for the default user. NOTE: You only need to do one of the above things in order for the server to start accepting connections from the outside.
Just in case some people would meet this use case ;)