No score breaks Html::escape

Open on Drupal.org →

Created on 12 June 2025, 25 days ago

Problem/Motivation

When Google is not able to determine a score NULL is saved in the logs. When trying to view the logs (with watchdog) an error is thrown because html::escape expects a string but got NULL.

Steps to reproduce

Somehow get an unscored validation from recaptcha
Try to view the watchdogs overview
Get an error

Proposed resolution

Always cast the score to a string. Incase the score is NULL it will be cast to an empty string which is fine when escaping the message.

Remaining tasks

User interface changes

API changes

Data model changes

🐛 Bug report

Status

Active

Version

1.1

Component

Code

Created by

🇳🇱Netherlands adebruin

Live updates comments and jobs are added and updated live.

Sign in to follow issues

Merge Requests

!8No score breaks Html::escape
Merged
Unnamed author
updated 24 days ago

Comments & Activities

Issue created by @adebruin
Merge request !8[3529856] fix: cast NULL to a string to allow for escaping → (Merged) created by Unnamed author
Comment 24 days ago →
🇳🇱Netherlands casey
Comment 24 days ago →
System Message

casey → committed 9c888549 on 1.0.x authored by adebruin →
Issue #3529856 by adebruin: No score breaks Html::escape
Comment 24 days ago →
🇳🇱Netherlands casey
Apparently ReCaptcha/Response::getScore() can return NULL

https://github.com/google/recaptcha/blob/master/src/ReCaptcha/Response.p...
https://github.com/google/recaptcha/blob/master/src/ReCaptcha/Response.p...

Thanks!
Comment 10 days ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024