- 🇨🇦Canada mandclu
The patch seems to change the indentation, which makes it difficult to see what code changes are actually being proposed. Can we get an updated patch that doesn't change the indentation? Also, it would be useful to know if the same changes are needed for the CKEditor5 version of the plugin introduced in the 2.1.x branch.
- Status changed to Needs review
3 months ago 3:39pm 28 May 2024 - 🇳🇱Netherlands nvandijk
I've tested 3244311-6.patch, running into a few issues.
The order of the elements changes on load of the editor.
To reproduce:- Place a details element in the editor
- Add multiple elements (
<p>
) to it - Change to 'source editing'
- Add some characters
- Change back to normal editing
- See the order of your items has changed.
Video demonstrating the issue → (also attached)
Some elements get stripped from the content of the details, such as heading elements.
To reproduce:- Place a details element in the editor
- Add a heading in the content of the editor
- Change to 'source editing'
- Add some characters
- Change back to normal editing
- See the heading has been converted to a
<p>
Video demonstrating the issue → (also attached)
Please note that this not only happens when switching from source editing to regular editing, also when re-opening the edit page after saving. Without switching in between the values in the database are 'correct' but get swapped when opening the editor again. Headings are still allowed, just disappear when opening the editor again.
- Status changed to Needs work
2 months ago 9:42am 26 June 2024