🇫🇮Finland @thatguy

Account created on 20 November 2013, over 10 years ago
#

Recent comments

🇫🇮Finland thatguy

Patch based on the core issue where the header is added in the render-function

🇫🇮Finland thatguy

There are no console errors and I have tested this with a clean 10.2.3-dev setup as well and the issue is present there too

🇫🇮Finland thatguy

Patch works for the 3.x version as well and fixes the error

🇫🇮Finland thatguy

I had issues with File field conditions and fixed them with this patch but it only applies for file fields. This issue would need more attention.

🇫🇮Finland thatguy

Here is a patch with marcoscanos fix from https://www.drupal.org/project/linkit/issues/2712951#comment-12605809 Linkit for Link field Fixed

🇫🇮Finland thatguy

I had this issue too and realised that it was caused by some extra route parameters coming from the Taxonomy menu. Here is a patch that includes removing the non-default route parameters, code copied from https://www.drupal.org/project/drupal/issues/3359511 🐛 [regression] missing menu active trail in Drupal 9.5.9 Needs work .

🇫🇮Finland thatguy

The patch from the linked redirect issue fixed this for me, thanks!

🇫🇮Finland thatguy

Noticed "page not found" errors with Adminimal trying to use the core stable paths for the icons. #9 patch fixed it nicely

🇫🇮Finland thatguy

Patch looks good to me too, please move forward with getting a D10 compatible release.

🇫🇮Finland thatguy

Patch #15 looks good to me, any chance of moving this forward to get D10 compatible version?

🇫🇮Finland thatguy

Patch from #4 seems to work for me. Any change of a new release for D10 support?

🇫🇮Finland thatguy

+1 for getting this merged ASAP so D10 upgrade is possible

🇫🇮Finland thatguy

@jeffschuler unfortunately there has come up other problems with using the file field as the controlled-by but these issues seem to exist without this patch as well so I'm going through other issues and trying to find help from those.

🇫🇮Finland thatguy

Patch from #138 seems to work well for me but I had two errors when having a File field as the "Controlled by" -field.

Error: Cannot use object of type Drupal\Core\StringTranslation\TranslatableMarkup as array in Drupal\conditional_fields\ConditionalFieldsFormHelper::evaluateDependencies() (line 657 of /app/web/modules/contrib/conditional_fields/src/ConditionalFieldsFormHelper.php)

Error: Cannot use object of type Drupal\Core\StringTranslation\TranslatableMarkup as array in Drupal\conditional_fields\ConditionalFieldsFormHelper::evaluateDependency() (line 834 of /app/web/modules/contrib/conditional_fields/src/ConditionalFieldsFormHelper.php)

I simply fixed these by adding a check is_array in the corresponding lines so feel free to fix if there is a larger logic issue related. Attached updated patch from #138 with those array check added.

🇫🇮Finland thatguy

Added a check if the mapping has been added in the media type, copied from Lendude's solution in https://www.drupal.org/project/drupal/issues/3185321#comment-14349402

🇫🇮Finland thatguy

Updated 3338187-group-v3-changes -branch, now Group content cloning seems to work correctly.

Still need to test Group user membership clone

🇫🇮Finland thatguy

I had the same issue and I got it working by adding this cache tag. I'm not sure if this is the correct place in code to add it though.

🇫🇮Finland thatguy

Re-rolled #12 to work with latest 3.x-dev version

🇫🇮Finland thatguy

Thanks @heddn that seems to fix the issue, although the problem is that I have to run it before updating to the latest dev-commit :D If there is other way to solve that would be nice but I can work with this I think.

Here are my steps that I needed to do, they are more complicated since these had to be done through deployments to couple of environments:

1. Create a patch with the post update hook posted by heddn at #5 and also include removal of dependency to menu_link_reference in group_content_menu.info.yml

2. Run patches but avoid updating module. Run update hook, uninstall menu_link_reference

3. Remove unneeded patches, update module

🇫🇮Finland thatguy

I have an issue with the submodule menu_link_reference being removed in the 3.0.x branch. I understand that the dev-versions can have this kind of things happening and we shouldn't use them but at the moment there isn't other way to do it with Group v3.

So I tried to update to the latest dev-commit but I received error for the missing menu_link_reference module. I manually removed the dependency to the menu_link_reference submodule, then uninstalled it and updated group_content_menu to the latest dev-commit. Now I receive error "Drupal\Core\Entity\EntityStorageException: The "field_item:menu_link_reference" plugin does not exist.".

Any ideas what I could do without breaking the existing group content menus?

🇫🇮Finland thatguy

Added check for the array key. Fixed issue for me so now I'm able to remove the file in node edit form.

🇫🇮Finland thatguy

Created a fork and added base changes in 3338187-group-v3-changes -branch. With these changes applied, you are able to clone a group but not any of its contents, users or other relations. Feel free to continue from here, I'm not sure when I will be able to.

🇫🇮Finland thatguy

Re-rolled patch from #11 to work with dev-3.0.x version. I also needed the patch from https://www.drupal.org/project/group/issues/2815971#comment-14881532 📌 More contexts needed Needs work to get the Group content menu to show correctly on node pages which belong to a Group.

🇫🇮Finland thatguy

Re-rolled patch from #40 to work with dev-3.0.x version

Production build 0.69.0 2024