Use filename in download

The last submitted patch, 2: media-entity-download-filename-in-download-3418334-2.patch, failed testing. View results →

Tested the patch #2 with Drupal 10.1.8 and media_entity_download 2.0.0. Seems to be working as intended on our site. The files now have the correct filenames as their names when downloading them.

I like the idea but I get the following:

Warning: Undefined array key "Content-Disposition" in Drupal\media_entity_download\Controller\DownloadController->download() (line 154 of modules/contrib/media_entity_download/src/Controller/DownloadController.php).
Drupal\media_entity_download\Controller\DownloadController->download(Object)

So maybe it should be turned around:

if (isset($headers['Content-Disposition']) && !empty($content_disposition = $headers['Content-Disposition'])) {
    // Key exists and is not empty, so we proceed with the logic.
    if (!str_contains($content_disposition, 'filename')) {
        $response->setContentDisposition($content_disposition, $filename);
    }
} else {
    // Key does not exist or is empty, so we set default disposition.
    if ($request_query->has(ResponseHeaderBag::DISPOSITION_INLINE)) {
        $disposition = ResponseHeaderBag::DISPOSITION_INLINE;
    } else {
        $disposition = ResponseHeaderBag::DISPOSITION_ATTACHMENT;
    }
    $response->setContentDisposition($disposition, $filename);
}

Or simply add a fallback:
if (empty($content_disposition = $headers['Content-Disposition'] ?? [])) {