Support for vm2 package discontinued with critical security advisories

Created on 18 July 2023, over 1 year ago
Updated 19 July 2023, over 1 year ago

Problem/Motivation

Drupal 9.5.x uses vm2 package which has discontinued support https://github.com/patriksimek/vm2 as well as security issues https://github.com/patriksimek/vm2/security/advisories/GHSA-cchq-frgv-rjh5.

Proposed resolution

Drop vm2 if possible since it has been done for D10. If not possible, consider update package degenerate to a newer version which does not require vm2 (this of course if vm2 is not needed as nothing else than dependency).

šŸ“Œ Task
Status

Active

Version

9.5

Component
JavascriptĀ  ā†’

Last updated 2 days ago

Created by

šŸ‡«šŸ‡®Finland thatguy

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @thatguy
  • Adding to what's above, this is the dependency tree:

    yarn why vm2
    yarn why v1.22.19
    [1/4] šŸ¤”  Why do we have the module "vm2"...?
    [2/4] šŸšš  Initialising dependency graph...
    [3/4] šŸ”  Finding dependency...
    [4/4] šŸš”  Calculating file sizes...
    => Found "vm2@3.9.12"
    info Reasons this module exists
       - "nightwatch#proxy-agent#pac-proxy-agent#pac-resolver#degenerator" depends on it
       - Hoisted from "nightwatch#proxy-agent#pac-proxy-agent#pac-resolver#degenerator#vm2"
    info Disk size without dependencies: "780KB"
    info Disk size with unique dependencies: "1.3MB"
    info Disk size with transitive dependencies: "1.3MB"
    info Number of shared dependencies: 2
    āœØ  Done in 0.17s.
    

    It looks like upstream is working on it: https://github.com/TooTallNate/proxy-agents/issues/218

  • šŸ‡¦šŸ‡ŗAustralia mstrelan

    This is fixed in proxy-agents as of 6.3.0, but we're only using proxy-agents because it's a dependency of nightwatch 1.6.x. In Drupal 10 and above we're using nightwatch 2.3.x which doesn't have this dependency. I suspect there won't be a new 1.6.x release of nightwatch so we might be stuck with this for Drupal 9.

  • šŸ‡«šŸ‡®Finland thatguy

    Opened issue to Nightwatch https://github.com/nightwatchjs/nightwatch/issues/3820 and we will see.

Production build 0.71.5 2024