Support CKEditor5

Have made a good start / proof of concept on the MR.

Ready for review - ran out of time for tests today - keen on initial feedback before pushing futher.

Attached stable patch for use with composer.

Thank you ericgsmith. I like the solution. I'll try to review it and merge asap.

This appears to work really will, thank you.

I tidied up the README.md file a little.

Tested and it does seem to work nicely. Thanks!

One possible improvement could be the ability to specify a form display mode in the settings for editing the modal.

@loze: That's a great idea, but I think it could be done in a separate issue.

In testing we noticed that the edit icon shows for media items even if the user doesn't have access to edit the specific media item; this is a common problem when some roles have permission to edit media they personally upload but not all media. Right now if a user in this situation clicks the edit icon they don't see anything - there's a console message (403 error from the request) but they don't know what's going on.

FYI when using this patch you might run into a core bug: 🐛 Why does Route access checking differ from Entity access checking? Needs work

Is there any way to hide the icon if the person doesn't have access? From what I can see it always shows the icon and then core fails to handle the permissions properly on the AJAX callback.

I think this could be committed as-is with a note about permissions, and then the icon permissions handled separately as I suspect most sites will be ok with it.

This repalces the permission check so it checks "update" instead of "edit".

I can confirm that the patch from #12 works as expected.
Thanks!

Patch #19 with the access check change is working very well for us.

+1 for patch in #19. Thanks guys!

ericgsmith → closed merge request !1

Thanks @DamienMcKenna for the fix on the access!

Closing MR and hiding old patches so latest patch is clear.

+1 for #19 thanks

Thanks for this great patch that helped us re-gain the capability to view/edit embedded media after upgrading to CKEditor5. I did run into an issue that when the editor does not have "update" permission on the media, clicking on the "Edit media" button would fail silently. The other issue down the road is that the CoreEditorMediaDialog class will also be removed in Drupal 11. In this new patch, the button will open the edit page in a new tab if the current user has the "update media" permission. Otherwise it opens the view page.

New release is here https://www.drupal.org/project/edit_media_modal/releases/2.0.0 →

Thank you blade_ukraine!

Recreated the patch in #27 for v2.0.0 in case anyone else needs it.

Automatically closed - issue fixed for 2 weeks with no activity.

I've opened a new bug for the broken button issue reported in #27.

https://www.drupal.org/project/edit_media_modal/issues/3533828 🐛 Edit media button broken with insufficient permissions Active