The Needs Review Queue Bot โ tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.
Consult the Drupal Contributor Guide โ to find step-by-step guides for working with issues.
- Status changed to Needs review
almost 2 years ago 10:47am 31 January 2023 - ๐ท๐ดRomania amateescu
Rerolled the patch for 10.1.x. Still needs accessibility review...
- ๐ท๐ดRomania amateescu
Fixed that test failure, we need to keep the
#title
property on each row in the list builder because we use it in the off-canvas switcher. - ๐ฎ๐ณIndia nayana_mvr
Verified the patch #12 and tested it on Drupal version 10.1.x. The patch works fine. Now the active workspace row is highlighted with a strong emphasis on the workspace label, and add an
(active)
suffix. I have added the before and after screenshots for reference. - Status changed to Needs work
over 1 year ago 2:52pm 3 March 2023 - ๐บ๐ธUnited States smustgrave
Brought this up in the accessibility channel
From @rkoller
well a sighted user gets the success message that the workspace was changed successfully. for one in the upper right corner of the admin toolbar (showing the new active workspace) and within the success message box. in voiceover you got only announced the confirmation step do you want to change the workspace. after pressing cmd option space to click the confirm button you immediately get skip to main content announced. no success message. if i would only rely onto my ears it might be troubeling
Think we need to announce when a workspace is switched or announce the active one one.
- ๐ฉ๐ชGermany rkoller Nรผrnberg, Germany
while writing up a comment to another issue in the workspaces queue i realized one detail that is missing for screenreader users. After a brief search i've rediscovered this one (already forgot it existed and i've already commented on)
One detail that might be considered to be added to the current MR which might help screenreader users tremendously is adding the active workspace to the title tag in the head. Currently the title is:
[h1] | [site name]
that might be change to:
[h1] | [active workspace] workspace | [site name]
so that you get for example when you are on
/admin/structure/types
Content types | Stage workspace | My Drupal site
The title might become a bit verbose and lengthy but that way all the necessary information is frontloaded, LTR from the specific to the more general (the screen reader user is able to jump off at any point). that means first you have the h1 then the active workspace and then finally the site name. and since screenreaders get the page title announced when loading a page the overall context would be provided satisfying WCAG 2.2. SC 2.4.2. (i've added also the tag wcag242)