Target="_blank" attribute add to external links.

Created on 18 January 2016, over 9 years ago
Updated 3 August 2024, about 1 year ago

Problem/Motivation

I got a PHP Manual external links in Date & Time Format section. If you click on the link It will be opened in the same window. Problem is after choosing the php date & time format I have to click on the browser back button to come again my Drupal site.

Currently has $description = $this->t('A user-defined date format. See the <a href="http://php.net/manual/function.date.php">PHP manual</a> for available options.');

Proposed resolution

I think, If the link would be opened in new tab then user can see the php date & time manual and add the date & time format easily.

Like-
$description = $this->t('A user-defined date format. See the <a href="http://php.net/manual/function.date.php" target="_blank">PHP manual</a> for available options.');

Remaining tasks

Postponed on #2702881: [policy, no patch] Formalize how external links are handled in core β†’

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

πŸ“Œ Task
Status

Postponed

Version

11.0 πŸ”₯

Component
UI textΒ  β†’

Last updated 26 days ago

No maintainer
Created by

πŸ‡§πŸ‡©Bangladesh imrancluster

Live updates comments and jobs are added and updated live.
  • Needs backport to D7

    After being applied to the 8.x branch, it should be considered for backport to the 7.x branch. Note: This tag should generally remain even after the backport has been written, approved, and committed.

  • Needs issue summary update

    Issue summaries save everyone time if they are kept up-to-date. See Update issue summary task instructions.

  • Needs accessibility review

    Used to alert the accessibility topic maintainer(s) that an issue significantly affects (or has the potential to affect) the accessibility of Drupal, and their signoff is needed (see the governance policy draft for more information). Useful links: Drupal's accessibility standards, the Drupal Core accessibility gate.

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • πŸ‡³πŸ‡ΏNew Zealand quietone

    Remove tag until the

  • Status changed to Active 3 months ago
  • πŸ‡³πŸ‡ΏNew Zealand quietone
  • πŸ‡³πŸ‡ΏNew Zealand quietone
  • πŸ‡ΊπŸ‡ΈUnited States xjm

    Interestingly, the original IS requested the opposite of the current scope and accessibility best practice. Updating the IS to avoid confusion.

    This is at least wrong in core everywhere the string the documentation for PHP date formats appears, and in the empty text for the frontpage view. And maybe the announcements feed.

  • πŸ‡ΊπŸ‡ΈUnited States xjm

    Better scope.

  • πŸ‡¨πŸ‡¦Canada mgifford Ottawa, Ontario

    Thanks for updating this @xjm.

    We do indeed want to remove the target="_blank" attribute where we can.

  • πŸ‡ΊπŸ‡ΈUnited States xjm

    Tag cleanup. (We don't actually need a11y review right now, and I did the IS update.)

  • πŸ‡ΊπŸ‡ΈUnited States xjm

    I guess whether or not the date format links should open a new window is debatable, because technically they could be on a multistep form. I would still lean toward removing them. We can probably have an accessibility maintainer give feedback on that once we've identified the full scope of what core does.

    A novice could work on this. The next step on the issue is to search for all the uses of target="_blank" in core, and document a list of which category the fall under as I've outlined them in the issue summary. Pay careful attention to the instructions in the issue summary.

Production build 0.71.5 2024