Allow ajax dialog to have focus configurable

git fetch drupal-3344259
ssh: connect to host git.drupal.org port 22: Operation timed out
fatal: Could not read from remote repository.

bleh

Trying again next week

The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

new branch created against 10.1.x

Issue with the last line "(jQuery, Drupal)..." isn't there.

Let's test.

Rebased to be up-to-date.

There may be an accessibility issue with changing this.

So this may be an accessibility regression according to docs like https://usability.yale.edu/web-accessibility/articles/focus-keyboard-ope... when a modal or dialog open focus needs to move into the modal.

Opened MR against 11.x to move forward.
What are the exact issues and are there any suggestions how to tackle these?

Hi @Gauravvvv, what did you change? Could you explain what you did?

Hi @tim-diels, There were some unwanted whitespaces in the core/misc/dialog/dialog.ajax.jsfile, which leads to Custom commands failure. I fixed them.

this is not necessary anymore as of 10.2.x

There is already a fix inside of the JS. Nicely done.