Rename Views method render_item() to renderItem() in MultiItemsFieldHandlerInterface

Created on 14 August 2019, over 5 years ago
Updated 9 August 2024, 5 months ago

Looks like it was missed in #2003330: Rename Views method render_items() to renderItems() โ†’ .

Remaining tasks

Notify this change to contrib modules as we can by creating new issues.

๐Ÿ“Œ Task
Status

Needs work

Version

11.0 ๐Ÿ”ฅ

Component
Viewsย  โ†’

Last updated 2 days ago

Created by

๐Ÿ‡ณ๐Ÿ‡ฟNew Zealand RoSk0 Wellington

Live updates comments and jobs are added and updated live.
  • Needs change record

    A change record needs to be drafted before an issue is committed. Note: Change records used to be called change notifications.

Sign in to follow issues

Merge Requests

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • ๐Ÿ‡ณ๐Ÿ‡ฟNew Zealand quietone

    I don't think this deprecation work is a suitable first issue. Also, unassigning due to no recent activity here.

  • First commit to issue fork.
  • Pipeline finished with Success
    5 months ago
    Total: 528s
    #249062
  • Status changed to Needs review 5 months ago
  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia vinmayiswamy

    Hi,

    Iโ€™ve made the necessary updates to address the deprecation of the render_item() method. Hereโ€™s a summary of the changes:

    Code Changes: The render_item() method has been replaced with renderItem() across the affected files. The deprecated method now triggers a deprecation notice, guiding developers to use the new method.

    Documentation: The doc blocks in the relevant files have been updated to reflect the deprecation.

    Change Record: A change record โ†’ has been drafted, detailing the deprecation of render_item() in Drupal 11.x and its removal in Drupal 12.x, with a reference to the issue for further context.

    Please review the changes and kindly advise if any further modifications are required.

    Thanks!

  • Status changed to Needs work 4 months ago
  • ๐Ÿ‡บ๐Ÿ‡ธUnited States smustgrave

    Deprecation link should point to the CR not the issue.

    Also since this probably used in a few contrib spots (I know I have a module or two that uses render_items) believe we need simple legacy test to verify deprecation message.

  • Pipeline finished with Success
    4 months ago
    Total: 890s
    #251121
  • Pipeline finished with Failed
    4 months ago
    Total: 228s
    #268923
  • Status changed to Needs review 4 months ago
  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia vinmayiswamy

    Hi, Iโ€™ve added tests to address the deprecation of the render_item() method.

    Kindly review the changes and please let me know if any further modifications are required.

    Thanks!

  • Pipeline finished with Failed
    4 months ago
    Total: 1508s
    #268959
  • Status changed to Needs work 4 months ago
  • ๐Ÿ‡บ๐Ÿ‡ธUnited States smustgrave

    So deprecation tests should be triggered by calling the method. Example testDeprecateRenderPlain

  • ๐Ÿ‡ณ๐Ÿ‡ฟNew Zealand quietone
  • Pipeline finished with Failed
    4 months ago
    Total: 8892s
    #273217
  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia vinmayiswamy

    Hi, I have updated the test cases to ensure that deprecation warnings are triggered by calling the deprecated methods directly, as per the feedback.

    Please review the changes and let me know if any further adjustments are needed. Your feedback is appreciated.

    Thanks!

  • Status changed to Needs review 4 months ago
  • Status changed to Needs work 4 months ago
  • ๐Ÿ‡บ๐Ÿ‡ธUnited States smustgrave
  • Pipeline finished with Canceled
    4 months ago
    Total: 185s
    #274411
  • Pipeline finished with Canceled
    4 months ago
    #274415
  • Pipeline finished with Canceled
    4 months ago
    Total: 92s
    #274416
  • Pipeline finished with Failed
    4 months ago
    Total: 631s
    #274417
  • Pipeline finished with Failed
    4 months ago
    #274425
  • Pipeline finished with Failed
    4 months ago
    Total: 887s
    #274608
  • Pipeline finished with Failed
    2 months ago
    Total: 2328825s
    #287900
  • First commit to issue fork.
  • Pipeline finished with Failed
    2 months ago
    Total: 694s
    #313870
  • Pipeline finished with Failed
    2 months ago
    Total: 590s
    #316782
  • Pipeline finished with Failed
    2 months ago
    Total: 812s
    #317281
  • Pipeline finished with Failed
    2 months ago
    Total: 610s
    #317328
  • Pipeline finished with Success
    2 months ago
    Total: 633s
    #317393
  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia arunkumark Coimbatore

    Resolved the Test case failures.

  • ๐Ÿ‡บ๐Ÿ‡ธUnited States smustgrave

    Should of noticed before but issue summary is incomplete. Full template should be used.

    2 nitpicky comments on MR but rest seems addressed

  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia arunkumark Coimbatore
  • Pipeline finished with Success
    about 2 months ago
    Total: 575s
    #329793
Production build 0.71.5 2024