- ๐ณ๐ฟNew Zealand quietone
I don't think this deprecation work is a suitable first issue. Also, unassigning due to no recent activity here.
- First commit to issue fork.
- Merge request !9139Issue #3074719 - Deprecate 'render_item()' Method and Introduce 'renderItem()'... โ (Open) created by vinmayiswamy
- Status changed to Needs review
5 months ago 12:27pm 9 August 2024 - ๐ฎ๐ณIndia vinmayiswamy
Hi,
Iโve made the necessary updates to address the deprecation of the
render_item()
method. Hereโs a summary of the changes:Code Changes: The
render_item()
method has been replaced withrenderItem()
across the affected files. The deprecated method now triggers a deprecation notice, guiding developers to use the new method.Documentation: The doc blocks in the relevant files have been updated to reflect the deprecation.
Change Record: A change record โ has been drafted, detailing the deprecation of
render_item()
in Drupal 11.x and its removal in Drupal 12.x, with a reference to the issue for further context.Please review the changes and kindly advise if any further modifications are required.
Thanks!
- Status changed to Needs work
4 months ago 1:46pm 9 August 2024 - ๐บ๐ธUnited States smustgrave
Deprecation link should point to the CR not the issue.
Also since this probably used in a few contrib spots (I know I have a module or two that uses render_items) believe we need simple legacy test to verify deprecation message.
- Status changed to Needs review
4 months ago 7:30am 30 August 2024 - ๐ฎ๐ณIndia vinmayiswamy
Hi, Iโve added tests to address the deprecation of the
render_item()
method.Kindly review the changes and please let me know if any further modifications are required.
Thanks!
- Status changed to Needs work
4 months ago 2:14pm 30 August 2024 - ๐บ๐ธUnited States smustgrave
So deprecation tests should be triggered by calling the method. Example testDeprecateRenderPlain
- ๐ฎ๐ณIndia vinmayiswamy
Hi, I have updated the test cases to ensure that deprecation warnings are triggered by calling the deprecated methods directly, as per the feedback.
Please review the changes and let me know if any further adjustments are needed. Your feedback is appreciated.
Thanks!
- Status changed to Needs review
4 months ago 10:44am 4 September 2024 - Status changed to Needs work
4 months ago 1:26pm 4 September 2024 - First commit to issue fork.
- ๐บ๐ธUnited States smustgrave
Should of noticed before but issue summary is incomplete. Full template should be used.
2 nitpicky comments on MR but rest seems addressed