Deprecate $variables['view'] for node.html.twig

nishtha.pradhan → made their first commit to this issue’s fork.

Added a deprecation notice for use $variables['view'].

Hi,
I've reviewed the MR and left a comment.
Please cover the deprecation part and revert the other changes.

Note: Issue URL should be replaced with the document URL of the deprecation.

cc: @catch

Thank you for your feedbacks @guptahemant & @ankitv18.
I have worked upon them and update the MR.
Please do let me know if any other changes are required.

@nishtha.pradhan, thanks for creating a change record for this issue, that is most helpful. Change records are published after an issue is committed and doing that is part of a core committer's tasks. So, please leave change records at draft. Thanks.

Left a comment on the MR.

But can we also add a deprecation test for this.

Hi,

I have verified MR !8663 on Drupal 11.x. The suggested changes have been implemented. I checked the deprecation message by creating a sample view for testing, and I can confirm that the deprecation message appears on the dump.

Please see the attached screenshot for reference.

Additionally, @smustgrave mentioned the possibility of adding a deprecation test for this. Do we need to include a deprecation test? If so, we may need to move this issue to NW. Otherwise, I'm giving a +1 to RTBC.

Thanks!

Tests are failing ~~ moving back to NW

Rebased the forked branch and pipelines are executed without any failure, hence moving into review

Should have some sort of test coverage

There is no special logic related to the deprecation so tests should not be needed. See point 3 of How to deprecate → . And we can see a previous example here, 📌 Deprecate $variables['teaser'] Fixed .

I updated the change record so the variable name and code are in code blocks. Also removed the phrase 'for now' as there is no intention to replace this.

Forgot to add that I searched for usages and found none.

 git grep view | grep node.html.twig

nod_ → closed merge request !8663

Committed 892c404 and pushed to 11.x. Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.