Use position: sticky for views sticky table header

working on it

Seems like a simple enough change.

Asked few questions on the MR

So searching for sticky-enabled and found just a few instances

But this one stood out

    once('tableheader', $(e.data.context).find('table.sticky-enabled')).forEach(
      (table) => {
        TableHeader.tables.push(new TableHeader(table));
      },
    );

If we are moving claro away from this should we deprecate this code?

Answered the threads in the MR (Claro does not have any use of the sticky-enabled class beyond the addition that I removed). I also created a followup issue to apply this solution to all of core and deprecate tableheader.js: 📌 consider deprecating tableheader.js in favor of css position:sticky Active . I'd like to keep the scope of this issue to Claro as it's a quick way to bring these benefits to the default admin theme, then we can apply it more broadly in the followup. The followup is where anything brought up in #7 would be addressed.

The only change made to the MR was reverting a template move in umami, so I'm switching this back to RTBC.

Responded in the MR

Responded to feedback, Claro now also replaces the sticky-enabled class in a preRender, and there is test coverage for it.

per #8 my initial issue was out of scope of this ticket. In scope of just claro believe the MR covers it. All threads resolved.

lauriii → closed merge request !4036

Made a minor docs adjustment on commit:

diff --git a/core/themes/claro/src/ClaroPreRender.php b/core/themes/claro/src/ClaroPreRender.php
index 985e3482d7..e18d0906c9 100644
--- a/core/themes/claro/src/ClaroPreRender.php
+++ b/core/themes/claro/src/ClaroPreRender.php
@@ -189,6 +189,9 @@ public static function messagePlaceholder(array $element) {
     return $element;
   }
 
+  /**
+   * Prerender callback for table elements.
+   */
   public static function tablePositionSticky(array $element) {
     if (isset($element['#attributes']['class']) && in_array('sticky-enabled', $element['#attributes']['class'])) {
       unset($element['#attributes']['class'][array_search('sticky-enabled', $element['#attributes']['class'])]);

Committed 3950243 and pushed to 11.x. Thanks!

Should we open a follow-up issue to move to position: sticky elsewhere and to deprecate Drupal.TableHeader?

Automatically closed - issue fixed for 2 weeks with no activity.

Follow up issue to deprecate drupal.tableheader https://www.drupal.org/project/drupal/issues/3439580 📌 Make drupal.tableheader only use CSS for sticky table headers Needs review