Set budgets rather than exact numbers of asset size assertions

Made a start - just did round numbers c500bytes bigger than the current assertions. That should allow for refactorings of existing files, but not entire new files to be added without making a change. If it's still awkward, we could increase them in another issue.

seems reasonable to me, and when we get over it we increase by 500b or something like that?

will most likely need a 10.3.x MR since it won't cherry pick :D

Committed d4fad8d and pushed to 11.x. Thanks!

Moving back to needs work for the 10.3.x version

(lol, crosspost)

Yeah this doesn't cherry-pick cleanly, leaving open for backport to 10.3.x.

Committed 05e4d1a and pushed to 11.x. Thanks!

10.3 MR is up.

The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

catch → changed the visibility of the branch 3441844-set-budgets-rather to hidden.

Hiding the 11.x MR to see if that makes needs review bot happier.

The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

looks good to me, bot is just getting in the way. it's not too smart to change the issue major version fast

Committed d250958 and pushed to 10.3.x. Thanks!

It's not too smart to change the issue major version fast

I'm not sure I agree with that. I think the needs review bot should work better.

I think the needs review bot should work better.

I agree, not much time for it though

quietone → closed merge request !7593

Lovely to see this change. Thanks everyone.

Reopening MR for 10.3.x for budgeting in more places. This is needed to avoid failures for changes such as the ones in this issue: https://www.drupal.org/project/drupal/issues/3439580 📌 Make drupal.tableheader only use CSS for sticky table headers Needs review

These changes where there for the MR for 11.x, but not for the one for 10.3.x.

Yes those were just missed. Committed/pushed to 10.3.x, thanks!

Automatically closed - issue fixed for 2 weeks with no activity.