- Merge request !1233Issue #3239139: Refactor (if feasible) uses of the jQuery animate function to use Vanilla/native → (Closed) created by Theresa.Grannum
- Status changed to Needs review
6 months ago 5:10am 28 February 2024 - Status changed to Needs work
6 months ago 9:33am 1 March 2024 - Status changed to Needs review
6 months ago 6:52am 6 March 2024 - Status changed to Needs work
6 months ago 10:17am 6 March 2024 - 🇫🇷France nod_ Lille
Thanks for the update but I don't think we understood each other, the goal is to replace jquery with native capabilities so if we need a 20 line function to replicate jQuery functionality it's not worth it.
Here I think we can replace the calls to .animate with the native .scrollTo() without a new function that does the animation.
- Status changed to Needs review
6 months ago 12:55pm 6 March 2024 - Status changed to RTBC
6 months ago 3:16pm 15 March 2024 - 🇺🇸United States smustgrave
Believe @nod_ feedback has been addressed on this one.
- Status changed to Needs work
6 months ago 4:19pm 15 March 2024 - Status changed to Needs review
6 months ago 5:48am 16 March 2024 - Status changed to Needs work
6 months ago 6:28am 16 March 2024 The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- Status changed to Needs review
6 months ago 4:00am 18 March 2024 - Status changed to RTBC
6 months ago 3:29pm 24 March 2024 - 🇺🇸United States smustgrave
Leaning into that @nod_ has reviewed this one already. But feedback appears to be addressed.
- 🇬🇧United Kingdom alexpott 🇪🇺🌍
alexpott → changed the visibility of the branch 3239139-refactor-if-feasible to hidden.
- Status changed to Needs work
6 months ago 8:49am 25 March 2024 - Status changed to Needs review
6 months ago 3:54pm 25 March 2024 - Status changed to RTBC
5 months ago 3:21pm 28 March 2024 - Status changed to Needs work
5 months ago 1:42pm 1 April 2024 - 🇫🇷France nod_ Lille
Regression when a pager is in a modal (like for the media library view), see MR comment. Do not just apply the suggestion, the whole block of code needs to be optimized, see MR comment.
- Status changed to Needs review
5 months ago 3:30pm 1 April 2024 - 🇫🇷France nod_ Lille
umm why did you add and removed the refactor? commits https://git.drupalcode.org/project/drupal/-/merge_requests/6737/diffs?co... + https://git.drupalcode.org/project/drupal/-/merge_requests/6737/diffs?co... are good, keep them :)
- 🇮🇳India shubh511
The second commit has double $ thats why was refactored in second commit
Btw this converting of scrollTarget to jquery failing the test cases
- 🇫🇷France nod_ Lille
thanks, that works, we can always improve later if needed, not breaking stuff is more important :)
- Status changed to RTBC
5 months ago 12:22pm 18 April 2024 - Status changed to Fixed
5 months ago 12:28pm 18 April 2024 - Status changed to Needs work
5 months ago 1:33pm 18 April 2024 - 🇬🇧United Kingdom alexpott 🇪🇺🌍
We need to fix the two test fails here... https://git.drupalcode.org/project/drupal/-/pipelines/150084/test_report...
It'll just be a case of changing numbers...
- Status changed to Needs review
5 months ago 1:52pm 18 April 2024 - Status changed to RTBC
5 months ago 2:01pm 18 April 2024 - Status changed to Fixed
5 months ago 2:02pm 18 April 2024 Automatically closed - issue fixed for 2 weeks with no activity.