Done
shubh_ → changed the visibility of the branch 3239161-refactor-if-feasible to hidden.
looks like some javascript test failure
All test passed...pls review @nod_
so what needs to do here can you pls guide ?
@nod_ all feedbacks resolved here, pls review it
Acknowledged feedbacks, not sure why pipeline failing checks...
so what exactly need to change here ?
The second commit has double $ thats why was refactored in second commit
Btw this converting of scrollTarget to jquery failing the test cases
Updated the issue feedbacks
Addressed the feedback given
Addressed the change..
Hey @nicxvan your comment has been addressed around the third category which was not captured by linter..
same here as well raised a MR for this issue but the problem is that it is failing pipeline and when fixing one test case will result in failing another test case and viceversa..
raised a MR for this issue but the problem is that it is failing pipeline and when fixing one test case will result in failing another test case and viceversa..
Addressed the change..
All feedback have been addressed..
shubh511 → made their first commit to this issue’s fork.
shubh511 → changed the visibility of the branch 3240103-refactored-deferred to hidden.
shubh511 → changed the visibility of the branch 3240103-refactored-deferred to active.
Addressed the feedback..
checking this issue..
Updated as per feedback..
Acknowledged all the feedbacks on MR..
ok, will check that
looking into this..
@mstrelan yes i rebased my branch with current updated 11.x still its showing the error..
Here, i am not able to figure out one remaining pipeline error which is Spell-check can anyone help to figureout what might be exactly the error is ?
I am working on this issue...