- Merge request !1241Issue #3239190: Refactor (if feasible) uses of the jQuery class function to use Vanilla/native → (Closed) created by Theresa.Grannum
- First commit to issue fork.
- First commit to issue fork.
- 🇮🇳India omkar-pd
Not sure why the Compilation check is failing at
yarn run -s check:ckeditor5
Can't see any error justERROR: Job failed: command terminated with exit code 1
- 🇫🇷France nod_ Lille
this does not seem like it would work. calling classlist on a jquery collection won't do much.
- 🇫🇷France nod_ Lille
The MR is just a search/replace and no code has been run apparently, closing the MR to avoid confusion, it needs to be reworked from scratch.
Please create a new branch from 11.x and start a new MR
- Status changed to Needs review
9 months ago 2:23pm 13 February 2024 - 🇺🇸United States smustgrave
Personally I'm not in favor of using
[0]
for the selector as I think it makes the readability go down. But will refer to the sub-maintainers for that. - Status changed to Needs work
8 months ago 8:13pm 15 March 2024 The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- Status changed to Needs review
8 months ago 10:19pm 15 March 2024 - Status changed to Needs work
8 months ago 10:48pm 15 March 2024 The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- Status changed to Needs review
8 months ago 4:34am 18 March 2024 - Status changed to Needs work
8 months ago 12:22pm 21 March 2024 The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- Status changed to Needs review
8 months ago 9:06am 28 March 2024 - Status changed to Needs work
8 months ago 9:48am 28 March 2024 The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- 🇫🇷France nod_ Lille
Please fix the merge conflicts before setting back to needs review, thanks
- Status changed to Needs review
8 months ago 5:56am 4 April 2024 - Status changed to Needs work
7 months ago 12:11pm 18 April 2024 The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- Status changed to Needs review
7 months ago 12:29pm 18 April 2024 - Status changed to Needs work
7 months ago 1:27pm 18 April 2024 The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- First commit to issue fork.
- Status changed to Needs review
5 months ago 5:28am 27 June 2024 - Status changed to Needs work
5 months ago 9:37pm 4 July 2024 The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- 🇳🇿New Zealand quietone
I answered the query in the MR and there are unresolved comments there.