Refactor (if feasible) uses of the jQuery deferred function to use Vanilla/native

Replaced deferred in toolbar.js with promise. Some tests are failing I'll try to fix those.

Fixed tests. Moving this to Needs Review.
Still, in ajax.js there is one$.Deferred().reject() that needs to be replaced. But looking for review before moving forward.

Not sure the feedback needed, but if the toolbar functionality is all there then should be good.

But won't know till the rule is added and all the fixes in.

Yes, the toolbar functionality working fine. The rule is added and tests are green. Moving this to Needs review.

Some of the comments around the changes mention a Defer not a Promise.

Changes done.

Refactor seems good.

I'm triaging RTBC issues → . I read the IS, the comments and the MR. I didn't find any unanswered questions or other work to do.

Nice to see work on these jQuery issues, thanks!

Leaving at RTBC.

Looks like this might break contrib. Toolbar Menu has nearly 7000 installs and uses Drupal.toolbar.setSubtrees which is refactored here.

https://git.drupalcode.org/project/toolbar_menu/-/blob/8.x-2.x/js/toolba...

If we can't add backward compatibility then we need a change record and ideally should create an issue in their queue to notify them that we are changing this API.

Also the comment in ajax.js still says:

@return {object}
  Returns the jQuery.Deferred object underlying the Ajax request. If
  pre-serialization fails, the Deferred will be returned in the rejected
  state.

This is no longer true, and I also wonder about backward compatibility here.

looking into this..

@shubh511,
No need to create a new PR. There is already a PR created for this.

Check if you can address the given feedback in #17 and #18 and make changes in the existing PR.

https://git.drupalcode.org/project/drupal/-/merge_requests/5792

omkar-pd → changed the visibility of the branch 3240103-refactored-deferred to hidden.

shubh511 → changed the visibility of the branch 3240103-refactored-deferred to active.

shubh511 → changed the visibility of the branch 3240103-refactored-deferred to hidden.

quietone → closed merge request !1278

Update IS