- First commit to issue fork.
- Merge request !4337Issue #3238867: Refactor (if feasible) uses of the jQuery parent function to use vanillaJS โ (Open) created by mstrelan
- last update
over 1 year ago Custom Commands Failed - First commit to issue fork.
- Status changed to Needs review
about 1 year ago 1:56pm 19 December 2023 - ๐ฎ๐ณIndia omkar-pd
Made remaining changes and Fixed tests for MR 4337.
- Status changed to Needs work
about 1 year ago 1:22am 29 December 2023 - Status changed to Needs review
about 1 year ago 7:09am 2 January 2024 - ๐บ๐ธUnited States smustgrave
smustgrave โ changed the visibility of the branch 3238867-refactor-if-feasible to hidden.
- ๐บ๐ธUnited States smustgrave
Believe feedback has been addressed but would like if it could get the thumbs up from @nod_
- Status changed to Needs work
11 months ago 3:05am 1 March 2024 - First commit to issue fork.
- Status changed to Needs review
11 months ago 4:51am 1 March 2024 - ๐บ๐ธUnited States smustgrave
Will leave for sub-maintainer but personally I find addition of
[0]
for selecting makes the UX go down. - Status changed to Needs work
9 months ago 12:10pm 18 April 2024 The Needs Review Queue Bot โ tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide โ to find step-by-step guides for working with issues.
- Status changed to Needs review
9 months ago 12:29pm 18 April 2024 - Status changed to Needs work
9 months ago 1:32pm 18 April 2024 The Needs Review Queue Bot โ tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide โ to find step-by-step guides for working with issues.
- ๐ฎ๐ณIndia shubh511
shubh_ โ made their first commit to this issueโs fork.
- First commit to issue fork.
- Status changed to Needs review
7 months ago 6:25am 27 June 2024 - Status changed to RTBC
7 months ago 1:55pm 27 June 2024 - ๐บ๐ธUnited States smustgrave
Believe all feedback has been addressed on this one.
- Status changed to Needs work
7 months ago 2:11pm 27 June 2024 - ๐ซ๐ทFrance nod_ Lille
we don't need to replace the customevent dispatch with jquery trigger, it's on purpose that it's a dom event now.
- Status changed to Needs review
7 months ago 7:05am 28 June 2024 - Status changed to RTBC
7 months ago 12:49pm 1 July 2024 - Status changed to Needs work
6 months ago 9:52am 17 July 2024 - ๐ซ๐ทFrance nod_ Lille
Thanks for sticking with it, found a way to simplify a number of selectors thanks to
:has()
- Status changed to Needs review
6 months ago 11:57am 17 July 2024 - ๐ซ๐ทFrance nod_ Lille
Thanks, I realized that 6 months ago I found the CSS only solution but browser support was not there yet, now it's been a while and all the supported browsers caught up.
- Status changed to RTBC
6 months ago 1:34pm 17 July 2024 - Status changed to Needs work
6 months ago 9:09pm 19 July 2024 - First commit to issue fork.
- Status changed to Needs review
5 months ago 10:27am 31 August 2024 - Status changed to RTBC
5 months ago 6:18pm 31 August 2024 - ๐บ๐ธUnited States smustgrave
Seems latest round of feedback has been addressed.
- Status changed to Needs work
4 months ago 8:35am 2 September 2024 - ๐ซ๐ทFrance nod_ Lille
Doing a last check, there are instances of .parent() left that are not detected by the jquery rule:
drupal core/misc (4 usages found) tabledrag.js (1 usage found) 337 columnIndex = cell.parent().find('> td').index(cell.get(0)) + 1; vertical-tabs.js (2 usages found) 237 .parent() 263 .parent() core/misc/dialog (1 usage found) dialog.position.js (1 usage found) 99 Math.round(event.data.$element.parent().outerHeight()) < core/modules/views_ui/js (2 usages found) views-admin.js (2 usages found) 392 .parent() 1220 this.$parent = this.$button.parent('div.views-expose, div.views-grouped');
- ๐ณ๐ฟNew Zealand quietone
For some reason I added an ignore to one of the instances identified in #39. I have removed that one. Unfortunately, I don't know how to change any of the remaining instances to vanillaJS.
If the rule is not detecting some instances how will future usages be avoided?