- First commit to issue fork.
- Merge request !4266Issue #3238882: Refactor (if feasible) uses of the jQuery prop function to use vanillaJS → (Open) created by mstrelan
- last update
12 months ago Custom Commands Failed - last update
12 months ago 29,558 pass, 1 fail - last update
12 months ago 29,559 pass - Status changed to Needs review
12 months ago 12:21am 27 June 2023 - Status changed to RTBC
12 months ago 4:12pm 27 June 2023 - 🇺🇸United States smustgrave
Refactor LGTM. Applied locally and didn't notice anything that broke.
- Open on Drupal.org →Environment: PHP 8.2 & MySQL 8last update
12 months ago Not currently mergeable. - Open on Drupal.org →Environment: PHP 8.2 & MySQL 8last update
12 months ago Not currently mergeable. - Open on Drupal.org →Environment: PHP 8.2 & MySQL 8last update
12 months ago Not currently mergeable. - Status changed to Needs work
12 months ago 4:56am 3 July 2023 The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
This does not mean that the patch needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
47:01 46:07 Running- Status changed to RTBC
10 months ago 1:43am 12 September 2023 - last update
10 months ago 30,150 pass - last update
9 months ago 30,161 pass - last update
9 months ago 30,160 pass, 1 fail - last update
9 months ago 30,168 pass - last update
9 months ago 30,164 pass, 2 fail - last update
9 months ago CI aborted - last update
9 months ago 30,363 pass - Status changed to Needs work
9 months ago 3:29am 27 September 2023 - 🇳🇿New Zealand quietone New Zealand
I'm triaging RTBC issues → . I read the IS which has no proposed resolution (although it is obvious by the title) but has remaining tasks.
I followed the steps in the first item of the remaining tasks and found that there are
✖ 42 problems (42 errors, 0 warnings)
. Based on that, this is not fixing all the usages of prop. I looked at the Meta to see if this is part of a set of issues to fix prop but found that this is the only issue. I presume then, that this is to fix all usages?Setting to needs work for an issue summary update and for the work on the other instances of prop in core. Although, if there is some reason they cannot be changed, then that should be documented in the IS.
Thanks
- Status changed to Needs review
9 months ago 10:51pm 27 September 2023 - 🇦🇺Australia mstrelan
@quietone which MR did you check? Should be all fixed up in !4266. We should close !1252 as it's against 9.3.x when we still compiled es6 files.
I've updated the issue summary to clarify the status.
- Status changed to RTBC
9 months ago 2:27pm 28 September 2023 - 🇺🇸United States smustgrave
Restoring status.
Verified locally MR 4266 still applies cleanly to 11.x
- last update
9 months ago 30,365 pass - last update
9 months ago 30,360 pass 4:27 22:00 Running- last update
9 months ago 30,379 pass - last update
9 months ago 30,377 pass - last update
9 months ago 30,382 pass - last update
9 months ago 30,392 pass - last update
9 months ago 30,397 pass - last update
8 months ago 30,397 pass - last update
8 months ago 30,413 pass - last update
8 months ago 30,417 pass 49:25 48:11 Running- last update
8 months ago 30,426 pass - 🇳🇿New Zealand quietone New Zealand
@mstrelan, I don't recall which MR I used. However, I repeated the steps with !4266 and didn't get any errors. I also closed the other MR. Thanks for the help.
- last update
8 months ago 30,436 pass - last update
8 months ago 30,438 pass - last update
8 months ago 30,464 pass - last update
8 months ago 30,481 pass - last update
8 months ago 30,483 pass - last update
8 months ago 30,486 pass - last update
8 months ago 30,486 pass - last update
8 months ago 30,510 pass - last update
8 months ago Custom Commands Failed - last update
8 months ago Custom Commands Failed - Status changed to Needs work
8 months ago 5:02am 13 November 2023 The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
This does not mean that the patch needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- Status changed to Needs review
7 months ago 5:50am 16 November 2023 - Status changed to RTBC
7 months ago 2:26pm 16 November 2023 - 🇺🇸United States smustgrave
Rebase seems good, reran nightwatch but was random failure.
- last update
7 months ago 30,558 pass - last update
7 months ago 30,602 pass - last update
7 months ago 30,604 pass - last update
7 months ago 30,605 pass - last update
7 months ago 30,668 pass - last update
7 months ago 30,675 pass - last update
7 months ago 30,679 pass - last update
7 months ago 30,686 pass - last update
7 months ago 30,688 pass - last update
7 months ago 30,686 pass, 1 fail - last update
7 months ago 30,696 pass 34:15 30:03 Running- last update
7 months ago 30,702 pass - last update
7 months ago 30,712 pass - last update
6 months ago 30,764 pass - last update
6 months ago 30,766 pass - last update
6 months ago 25,899 pass, 1,818 fail - last update
6 months ago 25,876 pass, 1,823 fail - last update
6 months ago 25,894 pass, 1,821 fail - last update
6 months ago 25,933 pass, 1,829 fail - last update
6 months ago 25,961 pass, 1,809 fail - last update
6 months ago 25,900 pass, 1,804 fail - last update
6 months ago 25,920 pass, 1,823 fail - last update
6 months ago 25,922 pass, 1,840 fail - last update
6 months ago 25,946 pass, 1,817 fail - last update
6 months ago 26,015 pass, 1,799 fail - last update
6 months ago CI error - Status changed to Needs work
6 months ago 1:13pm 11 January 2024 - 🇬🇧United Kingdom longwave UK
Added some comments/suggestions to the MR.
- Status changed to Needs review
4 months ago 1:06pm 28 February 2024 - Status changed to Needs work
4 months ago 2:40am 1 March 2024 - 🇫🇷France nod_ Lille
There are a couple of things to fix. I'm worried about some of the replacement that could lead to regression (aria-pressed, autofocus)
Having a bunch of .each all over the place is not ideal but there are no better way to deal with this.
- Status changed to Needs review
3 months ago 8:31am 28 March 2024 - Status changed to Needs work
3 months ago 9:57am 28 March 2024 The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- Status changed to Needs review
3 months ago 7:28am 4 April 2024 - Status changed to Needs work
2 months ago 6:15pm 13 April 2024 - 🇺🇸United States smustgrave
Re-ran javascript test failure twice and it failed both. So seems to be related to the change.
- First commit to issue fork.
- Status changed to Needs review
16 days ago 7:32am 10 June 2024 - Status changed to Needs work
11 days ago 4:58pm 14 June 2024 - 🇺🇸United States smustgrave
Left some comments on the MR.
@nod_ I tagged you in one if there's a change we want to keep?