Refactor (if feasible) uses of the jQuery prop function to use vanillaJS

Refactor LGTM. Applied locally and didn't notice anything that broke.

The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

Back to RTBC as per #10.

I'm triaging RTBC issues → . I read the IS which has no proposed resolution (although it is obvious by the title) but has remaining tasks.

I followed the steps in the first item of the remaining tasks and found that there are ✖ 42 problems (42 errors, 0 warnings) . Based on that, this is not fixing all the usages of prop. I looked at the Meta to see if this is part of a set of issues to fix prop but found that this is the only issue. I presume then, that this is to fix all usages?

Setting to needs work for an issue summary update and for the work on the other instances of prop in core. Although, if there is some reason they cannot be changed, then that should be documented in the IS.

Thanks

@quietone which MR did you check? Should be all fixed up in !4266. We should close !1252 as it's against 9.3.x when we still compiled es6 files.

I've updated the issue summary to clarify the status.

Restoring status.

Verified locally MR 4266 still applies cleanly to 11.x

quietone → closed merge request !1252

@mstrelan, I don't recall which MR I used. However, I repeated the steps with !4266 and didn't get any errors. I also closed the other MR. Thanks for the help.

The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

This does not mean that the patch needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

Rebase seems good, reran nightwatch but was random failure.

Added some comments/suggestions to the MR.

Will work on suggestions

There are a couple of things to fix. I'm worried about some of the replacement that could lead to regression (aria-pressed, autofocus)

Having a bunch of .each all over the place is not ideal but there are no better way to deal with this.

The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

Re-ran javascript test failure twice and it failed both. So seems to be related to the change.

Fixed the test.

Left some comments on the MR.

@nod_ I tagged you in one if there's a change we want to keep?

First of all thank you all for the hard work on this one, I've had to push a number of patches like this and I know how hard it is to keep up.

I'm going to try and refocus the jQuery removal work and to do that I need to take a few decisions. I'm going to close this issue for a few reasons:

• This MR is big, it impact a very big number of subsystems and make the code more brittle. jQuery is good at dealing with undefined elements, empty sets and so on, the DOM isn't. We already had regressions from a previous patch with undefined elements
• The MR is too big to review and make sure there are no regressions (even with the tests we already have), it would create unstability that we don't have to endure
• Every time I review this MR, I find a new bug
• Sometimes the jQuery code is simply more readable, I do not think this change is a net positive:
  

      const editSubmit = $(
        '.field-config-edit-form [data-drupal-selector="edit-submit"]',
      )[0];
      if (editSubmit) {
        editSubmit.disabled = true;
      }
  

  There is one line to change and just noticed a bug (jQuery doesn't have a forEach method)

I ported the credits to 📌 Credit for work on the reduce jQuery issues Active , which I will mark as fixed as soon as I go through all the others impacted jQuery issues.