Refactor (if feasible) uses of the jQuery attr function to use Vanilla/native

Below replacement needs to be done more.

/core/misc/machine-name.js
  157:11  error  Prefer getAttribute to $.attr  jquery/no-attr

/core/misc/tableresponsive.js
  40:28  error  Prefer Function#bind to $.proxy  jquery/no-proxy

/core/misc/tableselect.js
  72:16  error  Prefer setAttribute to $.attr  jquery/no-attr

/core/modules/block/js/block.admin.js
  26:24  error  Prefer getAttribute to $.attr  jquery/no-attr

/core/modules/comment/js/comment-new-indicator.js
  24:9   error  Prefer getAttribute to $.attr  jquery/no-attr
  28:22  error  Prefer getAttribute to $.attr  jquery/no-attr
  79:11  error  Prefer getAttribute to $.attr  jquery/no-attr
  82:24  error  Prefer getAttribute to $.attr  jquery/no-attr

/core/modules/comment/js/node-new-comments-link.js
   80:9   error  Prefer getAttribute to $.attr  jquery/no-attr
   83:19  error  Prefer getAttribute to $.attr  jquery/no-attr
   84:22  error  Prefer getAttribute to $.attr  jquery/no-attr
  125:11  error  Prefer setAttribute to $.attr  jquery/no-attr
  167:11  error  Prefer getAttribute to $.attr  jquery/no-attr
  170:24  error  Prefer getAttribute to $.attr  jquery/no-attr

/core/modules/contextual/js/views/AuralView.js
  43:9  error  Prefer setAttribute to $.attr  jquery/no-attr

/core/modules/editor/js/editor.admin.js
  1022:31  error  Prefer getAttribute to $.attr  jquery/no-attr

/core/modules/editor/js/editor.js
  17:21  error  Prefer getAttribute to $.attr  jquery/no-attr

/core/modules/file/file.js
  258:30  error  Prefer getAttribute to $.attr  jquery/no-attr
  261:9   error  Prefer setAttribute to $.attr  jquery/no-attr
  268:11  error  Prefer setAttribute to $.attr  jquery/no-attr
  291:7   error  Prefer setAttribute to $.attr  jquery/no-attr

/core/modules/layout_builder/js/layout-builder.js
   65:11  error  Prefer setAttribute to $.attr  jquery/no-attr
   70:11  error  Prefer setAttribute to $.attr  jquery/no-attr
  209:7   error  Prefer setAttribute to $.attr  jquery/no-attr
  238:18  error  Prefer getAttribute to $.attr  jquery/no-attr
  258:41  error  Prefer getAttribute to $.attr  jquery/no-attr
  374:51  error  Prefer getAttribute to $.attr  jquery/no-attr
  434:9   error  Prefer setAttribute to $.attr  jquery/no-attr

/core/modules/menu_ui/menu_ui.admin.js
  63:9  error  Prefer setAttribute to $.attr  jquery/no-attr

/core/modules/settings_tray/js/settings_tray.js
  168:76  error  Prefer getAttribute to $.attr  jquery/no-attr

/core/modules/system/js/system.modules.js
  66:11  error  Prefer setAttribute to $.attr  jquery/no-attr
  72:11  error  Prefer setAttribute to $.attr  jquery/no-attr
  86:11  error  Prefer setAttribute to $.attr  jquery/no-attr

/core/modules/system/tests/modules/js_message_test/js/js_message_test.js
  44:24  error  Prefer getAttribute to $.attr  jquery/no-attr
  46:13  error  Prefer getAttribute to $.attr  jquery/no-attr
  50:26  error  Prefer getAttribute to $.attr  jquery/no-attr

/core/modules/toolbar/js/views/ToolbarVisualView.js
  315:9  error  Prefer setAttribute to $.attr  jquery/no-attr
  319:9  error  Prefer setAttribute to $.attr  jquery/no-attr

Meanwhile can someone please review the MR :- https://git.drupalcode.org/project/drupal/-/merge_requests/5791#note_242353

The remaining task around the code-committ still seems needed.

There are several places that create a jquery object just to get the original dom element after. We can get rid of the creation of the jQuery object and use the dom directly

Addressed all feedbacks in MR. please review

Changes caused failures.

In the above raised MR, the Funtional Javascript test cases are failing and there are console errors as well

Resolved all failures. Please review

The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

Will leave for sub-maintainer to review but personally find adding [0] makes the readability go down.

The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

Issues in MR.

Sam Phillemon → made their first commit to this issue’s fork.

I have fixed the remaining MR-related issues.

For good practice can the MRs be cleanup/hidden. There are currently 4 branche

shubh_ → changed the visibility of the branch 3239161-refactor-if-feasible to hidden.

shubh_ → changed the visibility of the branch 3239161-10.1.x to hidden.

shubh_ → changed the visibility of the branch 9.3.x to hidden.

Done

The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

MR needs a manual rebase

First of all thank you all for the hard work on this one, I've had to push a number of patches like this and I know how hard it is to keep up.

I'm going to try and refocus the jQuery removal work and to do that I need to take a few decisions. I'm going to close this issue for a few reasons:

• This MR is big, it impact a very big number of subsystems and make the code more brittle. jQuery is good at dealing with undefined elements, empty sets and so on, the DOM isn't. We already had regressions from a previous patch with undefined elements
• The MR is too big to review and make sure there are no regressions (even with the tests we already have), it would create unstability that we don't have to endure
• Every time I review this MR, I find a new bug
• Sometimes the jQuery code is simply more readable, I do not think this change is a net positive:
  

            $details
              .filter('[data-drupal-system-state="forced-open"]')
              .removeAttr('data-drupal-system-state')
              .attr('open', false);
            $details.forEach((detail) => {
              if (
                detail.getAttribute('data-drupal-system-state') === 'forced-open'
              ) {
                detail.removeAttribute('data-drupal-system-state');
                detail.setAttribute('open', 'false');
              }
            });
  
  

  There is one line to change and just noticed a bug (jQuery doesn't have a forEach method)

I ported the credits to 📌 Credit for work on the reduce jQuery issues Active , which I will mark as fixed as soon as I go through all the others impacted jQuery issues.