rahulrasgon โ created an issue.
rahulrasgon โ changed the visibility of the branch 2887376-link-autocomplete-content to active.
rahulrasgon โ changed the visibility of the branch 2887376-link-autocomplete-content to hidden.
Please review the patch.
rahulrasgon โ created an issue.
@lisagodare, patch is not working after clicking on Load More Button on entity browser.
rahulrasgon โ created an issue.
Fixed all issue except eslint and PHPunit.
I would suggest to create a new issue for eslint warnings. Also, not sure why PHP unit cases are failing.
Thanks
Working on other warnings/errors.
rahulrasgon โ made their first commit to this issueโs fork.
Merged to 1.0.x.
Thanks!!
rahulrasgon โ created an issue.
MR is ready to review.
Thanks!!
Re-rolled for the current 3.x-dev.
Thanks!!
Below replacement needs to be done more.
/core/misc/machine-name.js
157:11 error Prefer getAttribute to $.attr jquery/no-attr
/core/misc/tableresponsive.js
40:28 error Prefer Function#bind to $.proxy jquery/no-proxy
/core/misc/tableselect.js
72:16 error Prefer setAttribute to $.attr jquery/no-attr
/core/modules/block/js/block.admin.js
26:24 error Prefer getAttribute to $.attr jquery/no-attr
/core/modules/comment/js/comment-new-indicator.js
24:9 error Prefer getAttribute to $.attr jquery/no-attr
28:22 error Prefer getAttribute to $.attr jquery/no-attr
79:11 error Prefer getAttribute to $.attr jquery/no-attr
82:24 error Prefer getAttribute to $.attr jquery/no-attr
/core/modules/comment/js/node-new-comments-link.js
80:9 error Prefer getAttribute to $.attr jquery/no-attr
83:19 error Prefer getAttribute to $.attr jquery/no-attr
84:22 error Prefer getAttribute to $.attr jquery/no-attr
125:11 error Prefer setAttribute to $.attr jquery/no-attr
167:11 error Prefer getAttribute to $.attr jquery/no-attr
170:24 error Prefer getAttribute to $.attr jquery/no-attr
/core/modules/contextual/js/views/AuralView.js
43:9 error Prefer setAttribute to $.attr jquery/no-attr
/core/modules/editor/js/editor.admin.js
1022:31 error Prefer getAttribute to $.attr jquery/no-attr
/core/modules/editor/js/editor.js
17:21 error Prefer getAttribute to $.attr jquery/no-attr
/core/modules/file/file.js
258:30 error Prefer getAttribute to $.attr jquery/no-attr
261:9 error Prefer setAttribute to $.attr jquery/no-attr
268:11 error Prefer setAttribute to $.attr jquery/no-attr
291:7 error Prefer setAttribute to $.attr jquery/no-attr
/core/modules/layout_builder/js/layout-builder.js
65:11 error Prefer setAttribute to $.attr jquery/no-attr
70:11 error Prefer setAttribute to $.attr jquery/no-attr
209:7 error Prefer setAttribute to $.attr jquery/no-attr
238:18 error Prefer getAttribute to $.attr jquery/no-attr
258:41 error Prefer getAttribute to $.attr jquery/no-attr
374:51 error Prefer getAttribute to $.attr jquery/no-attr
434:9 error Prefer setAttribute to $.attr jquery/no-attr
/core/modules/menu_ui/menu_ui.admin.js
63:9 error Prefer setAttribute to $.attr jquery/no-attr
/core/modules/settings_tray/js/settings_tray.js
168:76 error Prefer getAttribute to $.attr jquery/no-attr
/core/modules/system/js/system.modules.js
66:11 error Prefer setAttribute to $.attr jquery/no-attr
72:11 error Prefer setAttribute to $.attr jquery/no-attr
86:11 error Prefer setAttribute to $.attr jquery/no-attr
/core/modules/system/tests/modules/js_message_test/js/js_message_test.js
44:24 error Prefer getAttribute to $.attr jquery/no-attr
46:13 error Prefer getAttribute to $.attr jquery/no-attr
50:26 error Prefer getAttribute to $.attr jquery/no-attr
/core/modules/toolbar/js/views/ToolbarVisualView.js
315:9 error Prefer setAttribute to $.attr jquery/no-attr
319:9 error Prefer setAttribute to $.attr jquery/no-attr
Meanwhile can someone please review the MR :- https://git.drupalcode.org/project/drupal/-/merge_requests/5791#note_242353
rahulrasgon โ made their first commit to this issueโs fork.
Patch provided in https://www.drupal.org/project/config_token/issues/3331946#comment-14858795 ๐ Fix the issues reported by phpcs Needs review is relative to the project root directory not relative to the module directly.
Created the correct MR for easy merge https://git.drupalcode.org/project/config_token/-/merge_requests/3
Also verify by running the following command
phpcs --standard=โDrupal,DrupalPracticeโ --extensions=php,module,inc,install,test,profile,theme,info,txt,md,yml
No issues are reported now.
Thanks
Please review.
rahulrasgon โ changed the visibility of the branch 8.x-1.x to hidden.
rahulrasgon โ made their first commit to this issueโs fork.
rahulrasgon โ created an issue.
Fixed as a part of https://www.drupal.org/project/ckeditor_preview/issues/3407499#comment-1... ๐ Automated Drupal 10 compatibility fixes Fixed
Committed to 1.0.x branch. Thanks!!
Commited to 3.0.x and 8.x 1.x branches.
rahulrasgon โ made their first commit to this issueโs fork.
Committed to 3.0.x branch.
Committed to 8.x-1.x branch.
rahulrasgon โ made their first commit to this issueโs fork.
New Drupal 10 compatible released.
https://www.drupal.org/project/video_embed_tiktok/releases/1.0.0 โ
Thanks
Fixed as a part of
https://www.drupal.org/project/video_embed_tiktok/issues/3276183#comment...
๐
json_decode return objects rather than array.
Fixed
Thanks
Commited to 1.0.x branch.
rahulrasgon โ made their first commit to this issueโs fork.
Commited to 1.0.x branch.