I have fixed the remaining MR-related issues.
@alexpott Ah, now I understand what you're saying. It caught me off guard a bit when I noticed the build was green. Thank You!
I've noticed a significant number of files have been affected by this max-len check (as mentioned in #31), and I'm unsure whether resolving this should be included in this particular issue or handled separately. Therefore, I'm uncertain about the appropriate procedure.
Sam Phillemon → made their first commit to this issue’s fork.
@alexpott - I've made the suggested changes to the .gitlab-ci.yml file, but unfortunately, the eslint job is still failing. Could you kindly confirm whether the proposed changes are correct or if there's something I might be overlooking?
So I have made the suggested changes mentioned and also kept the ':visible' as it is for now.
I have rebased the branch as well. Now it is up to date.
I have added the changes suggested in #27 in the file '.eslintrc.passing.json'. Also, I am seeing a lot of files get affected because of this max-len check. I am unsure whether this needs to be fixed as part of this issue or if it needs to be taken care of separately. It would be great if someone could suggest what approach is required. Below is just a sample of how the error looks for one of the files:
/Users/sam/workspace/project/drupal/core/modules/views_ui/js/views-admin.js
224:1 error This line has a length of 82. Maximum allowed is 80 max-len
239:1 error This line has a length of 81. Maximum allowed is 80 max-len
537:1 error This line has a length of 82. Maximum allowed is 80 max-len
538:1 error This line has a length of 81. Maximum allowed is 80 max-len
547:1 error This line has a length of 91. Maximum allowed is 80 max-len
568:1 error This line has a length of 82. Maximum allowed is 80 max-len
742:1 error This line has a length of 81. Maximum allowed is 80 max-len
770:1 error This line has a length of 83. Maximum allowed is 80 max-len
849:1 error This line has a length of 82. Maximum allowed is 80 max-len
937:1 error This line has a length of 82. Maximum allowed is 80 max-len
1027:1 error This line has a length of 82. Maximum allowed is 80 max-len
1030:1 error This line has a length of 82. Maximum allowed is 80 max-len
Sam Phillemon → made their first commit to this issue’s fork.
I am facing issues with the PHP unit tests. I have tried fixing some of them but it is causing others to fail. It would be great if someone else could have a look at it.
Sam Phillemon → made their first commit to this issue’s fork.
Sam Phillemon → changed the visibility of the branch 3239127-refactor-trigger to hidden.
Removed the DrupalCI testing script. can you please let me know what other issues you are seeing?
currently looking into this
I have looked into this issue and didn't find any js related linting issues.
I am currently working on this issue.
I am facing issues with the PHP unit tests. I am new to this and I have fixed some of them but I am unable to fix the remaining. Can someone please help with it?