Use .once() to prevent adding multiple confirmation dialogs

Patch for the MR.

Hello, thanks for reporting, with that said, I'm wondering which theme are you supporting? Which administrative theme are you using? Which theme is being used when these dialogs are invoked?

Is it a core or a contrib theme?

@joseph.olstad You should be able to reproduce this error after Drupal 10.1.0 with Claro theme and lates vbo module.

ah sorry I'm mostly using version 2 not version 3

I'll try to review your findings soon.

Hi, @dipakmdhrm
I'm not able to reproduce the issue on my D10 instance with the latest version of the module as well as the latest vbo module in claro theme, but I think its always a good practice to use once() with the context in these type of circumstances, it'll prevent the said issue if it happens to occur in any case though, as I see that the once() function is not implemented in the latest version's js code, I personally feel that it'll be better to incorporate the same.

The MR looks good to me, and can be merged!
As I couldn't reproduce the same so I can't actually move it to RTBC, hence I'm changing the state to NR to help the ticket move forward!
CC: @joseph.olstad

seems like a good change but I haven't had a chance to test this.

So @sourojeetpaul, you tested this and it's good?

Hi @joseph.olstad,

As I've mentioned in my previous comment, even I couldn't reproduce the issue on my Drupal instance, I tried to reproduce the same on Drupal 10.2 and the specified version of the module, but haven't encountered any such issues.

But the MR looks good to me, and it incorporates the once() function, which should be the preferable approach in such cases.

I applied the patch and tested it thoroughly, nothing seems to be breaking on applying it!

Though, it'll be better if we can add 'Steps to Reproduce' in a more detailed manner, which is absolutely missing now!
@dipakmdhrm can you pls attach some screenshots or screen recordings of the issue that you're encountering.

Rest the MR looks good and we can ship it!

https://www.drupal.org/project/moderated_content_bulk_publish/releases/3... →

Automatically closed - issue fixed for 2 weeks with no activity.