- Issue created by @dipakmdhrm
- Merge request !21Remove the confirmation dialog for a publish-to-publish state switch. โ (Merged) created by dipakmdhrm
- First commit to issue fork.
- Merge request !30Disable the "dialog on node edit form" when updating a published node without changing it's moderation state. โ (Closed) created by balagan
- Status changed to Needs review
about 1 month ago 6:07pm 18 March 2025 - ๐ง๐ชBelgium baikho Antwerp, BE
Not sure why #6 was closed, this is still an issue on
3.0.x-dev
too - Merge request !34Issue #3395263: Disable the "dialog on node edit form" when updating a... โ (Open) created by baikho
- ๐จ๐ฆCanada joseph.olstad
joseph.olstad โ made their first commit to this issueโs fork.
- ๐จ๐ฆCanada joseph.olstad
Actually, this is by design, my bad, I will revert the commits.
I will update the label instead.
- ๐จ๐ฆCanada joseph.olstad
Sorry my bad, this is by design, my clients that want this confirmation box would be surprised if it isn't there confirming a publish action.
The proper way to deal with this would be a configuration setting, pass it to drupalSettings and implement that setting in the js.
- ๐จ๐ฆCanada joseph.olstad
Once this is correctly implemented as a configuration option then I'll re-consider merging. Should prompt by default, with an opt-out config setting.
- ๐จ๐ฆCanada joseph.olstad
commit a9fbc558d2969092b693412dcf36205bd6bc5fdd (HEAD -> 2.0.x, origin/HEAD, origin/2.0.x) Author: joseph.olstad <joseph.olstad@1321830.no-reply.drupal.org> Date: Wed Apr 16 00:42:24 2025 -0400 Change label diff --git a/src/Form/SettingsForm.php b/src/Form/SettingsForm.php index f2d4532..b77d97e 100644 --- a/src/Form/SettingsForm.php +++ b/src/Form/SettingsForm.php @@ -37,7 +37,7 @@ class SettingsForm extends ConfigFormBase { '#type' => 'checkbox', '#title' => $this->t('Enable dialog on node edit form'), '#default_value' => $config->get('enable_dialog_node_edit_form') ?? true, - '#description' => $this->t('It shows a confirmation dialog in edit form of any node type when state changes from non-published to published.'), + '#description' => $this->t('It shows a confirmation dialog when publishing a node from a node form.'), ]; $form['enable_dialog_admin_content'] = [ '#type' => 'checkbox',
- Merge request !38Issue #3395263 - Updated description for Enabling dialog on node edit form. โ (Closed) created by lavanyatalwar
- ๐ฎ๐ณIndia lavanyatalwar
Done with the changes @joseph.olstad,
Kindly review and merge :) - ๐จ๐ฆCanada joseph.olstad
Please see comment #16 and comment #17. This needs to be a configurable option.
- ๐ฎ๐ณIndia lavanyatalwar
Okay, I'll work on comments #16 and #17. Also, @joseph.olstad, there was a change in MR!38 as well. I'm attaching a screenshot for your reference, kindly have a look.