Disable the "dialog on node edit form" when updating a published node without changing it's moderation state.

balagan → closed merge request !30

Not sure why #6 was closed, this is still an issue on 3.0.x-dev too

joseph.olstad → made their first commit to this issue’s fork.

Actually, this is by design, my bad, I will revert the commits.

I will update the label instead.

Sorry my bad, this is by design, my clients that want this confirmation box would be surprised if it isn't there confirming a publish action.

The proper way to deal with this would be a configuration setting, pass it to drupalSettings and implement that setting in the js.

Once this is correctly implemented as a configuration option then I'll re-consider merging. Should prompt by default, with an opt-out config setting.

commit a9fbc558d2969092b693412dcf36205bd6bc5fdd (HEAD -> 2.0.x, origin/HEAD, origin/2.0.x)
Author: joseph.olstad <joseph.olstad@1321830.no-reply.drupal.org>
Date:   Wed Apr 16 00:42:24 2025 -0400

    Change label

diff --git a/src/Form/SettingsForm.php b/src/Form/SettingsForm.php
index f2d4532..b77d97e 100644
--- a/src/Form/SettingsForm.php
+++ b/src/Form/SettingsForm.php
@@ -37,7 +37,7 @@ class SettingsForm extends ConfigFormBase {
       '#type' => 'checkbox',
       '#title' => $this->t('Enable dialog on node edit form'),
       '#default_value' => $config->get('enable_dialog_node_edit_form') ?? true,
-      '#description' => $this->t('It shows a confirmation dialog in edit form of any node type when state changes from non-published to published.'),
+      '#description' => $this->t('It shows a confirmation dialog when publishing a node from a node form.'),
     ];
     $form['enable_dialog_admin_content'] = [
       '#type' => 'checkbox',

Looking into it.

Done with the changes @joseph.olstad,
Kindly review and merge :)

joseph.olstad → closed merge request !38

Please see comment #16 and comment #17. This needs to be a configurable option.

Okay, I'll work on comments #16 and #17. Also, @joseph.olstad, there was a change in MR!38 as well. I'm attaching a screenshot for your reference, kindly have a look.

@lavanyatalwar
Yes that change was made on purpose , it is the intended label.