Apply taxes on Shipping Promotions

Created on 28 January 2024, 10 months ago

Updated 11 April 2024, 7 months ago

If the shipping has Tax applied, and we create a Shipping percentage discount, the reduced amount is not calculated properly

I created a patch based on this issue: https://www.drupal.org/project/commerce/issues/2982355 🐛 Incorrect percentage discounts when prices are entered with tax, but displayed without (or vice-versa) Needs work which applies also tax for the discount amount.

This is a starting point, doesn't treat every cases at the moment only Applies ot the default tax rate of the order's tax type.

Feel free to contribute.

🐛 Bug report

Status

Needs work

Version

2.0

Component

Code

Created by

🇷🇴Romania cslevy

Live updates comments and jobs are added and updated live.

Comments & Activities

Issue created by @cslevy
Comment 10 months ago →
🇷🇴Romania cslevy
Patch need to be applied together with: https://www.drupal.org/project/commerce/issues/2982355 🐛 Incorrect percentage discounts when prices are entered with tax, but displayed without (or vice-versa) Needs work
Comment 8 months ago →
🇷🇴Romania cslevy
I recreated the patch, to apply the taxes to shipping promotions before calculating shipping taxes.
Comment 7 months ago →
🇮🇱Israel jsacksick
Tax is always applied post promotions... Which is also the commerce core tax behavior for order items?

Production build 0.71.5 2024