Footer copied over instead of setting the proper group?

Created on 19 December 2024, 3 days ago

Why is the footer copied over instead of setting the proper group?

Line 250 from GinContentFormHelper.php

// Copy footer over.
$form['gin_sidebar']['footer'] = ($form['footer']) ?? [];

instead of:

if (!empty($form['footer'])) {
  $form['footer']['#group'] = 'gin_sidebar';
}

I'm using a patch which enables the gin edit form for commerce product
"Enable Gin edit form for Commerce Product": "https://git.drupalcode.org/project/gin/-/merge_requests/255.patch",

But the Published checkbox is not shown.

Created a patch with the changes, please review

🐛 Bug report
Status

Needs review

Version

3.0

Component

Code

Created by

🇷🇴Romania cslevy

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @cslevy
  • 🇩🇪Germany jurgenhaas Gottmadingen

    @cslevy thanks for contributing to Gin. As for this issue, I have two requirements and hope you can go with them:

    • Please turn the patch into a feature branch with an MR, patches are not really used any longer.
    • As for the issue, can you provide step-by-step instructions on how that scenario you're fixing here can be reproduced and what the real problem is that needs fixing?
  • Merge request !556Resolve #3494988 "Footer copied over" → (Open) created by Unnamed author
  • Pipeline finished with Success
    1 day ago
    Total: 192s
    #375133
  • Pipeline finished with Success
    1 day ago
    Total: 186s
    #375138
  • 🇷🇴Romania cslevy

    @jurgenhaas thank you for your feedback.

    1. I created the merge request (this is my first merge request on drupal org :))
    2. I updated the description with the repro steps.

  • 🇩🇪Germany jurgenhaas Gottmadingen

    @cslevy I can't reproduce the problem. I followed your steps above, and the published checkbox shows below the body field.

    Is there maybe something else altering your form?

    However, I'm surprised why the checkbox is below the body and not in the sticky toolbar. @saschaeggi do you have any idea how that could be?

Production build 0.71.5 2024