- 🇦🇹Austria drunken monkey Vienna, Austria
Thanks for proposing this new feature!
As there is obviously enough interest in this, sure, we can add this new processor.However, in addition to fixing this with regards to existing tests, this should also get its own set of tests, as all new processors (or new code in general).
This will be fixed with ✨ Search API token field processor Fixed . Looking forward to the feedback on that issue.
- 🇺🇦Ukraine dmytro-aragorn Lutsk
Patch from #38 ✨ Index image style URLs Needs work doesn't applied for me and #20 ✨ Index image style URLs Needs work has an issue with opening edit form.
So I've made a re-roll of the patch from #20 ✨ Index image style URLs Needs work with a fix for edit form. - Status changed to Needs review
about 1 year ago 2:25pm 4 October 2023 - last update
about 1 year ago 361 pass, 116 fail - 🇺🇦Ukraine dmytro-aragorn Lutsk
The same issue was reached as in #29 ✨ Index image style URLs Needs work - an error is appear during indexing if the field doesn't exists in any of entity type from the index.
Here is an updated patch with prevent the error during indexing. The last submitted patch, 43: search-api-image-styles-urls-for-media-2962569-43.patch, failed testing. View results →
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.- Status changed to Needs work
about 1 year ago 9:22am 18 October 2023 - 🇷🇴Romania cslevy
Something is not ok with this patch.
When this was introduced
$container->get('entity_type.manager')->getStorage('media'),
if the Media module is not enabled, this breaks the whole search api functionality.
- Status changed to Needs review
9 months ago 1:11pm 15 March 2024 - 🇺🇦Ukraine dmytro-aragorn Lutsk
I've fixed the issue with the patch usage when the Media module is disabled and also corrected syntax for PHP 8.2 usage.
Do we need this issue?
Can this use case not be solved with genric Search API "Custom value" Property?@drunken monkey
Are you still open to support Image style Urls separately OR in favour of "Custom value" Property to close it ?
- Status changed to Postponed: needs info
9 months ago 10:02am 17 March 2024 - 🇦🇹Austria drunken monkey Vienna, Austria
If this can be resolved by just using the existing “Custom value“ field, then I’m in favor of closing this as “won’t fix” (or maybe “outdated”).
I confirm. We're indexing the image styles with “Custom value“ field from a long time.
- Status changed to Closed: won't fix
9 months ago 12:03pm 24 March 2024 - 🇦🇹Austria drunken monkey Vienna, Austria
OK, then let’s just close this. Thanks again!