- 🇦🇹Austria drunken monkey Vienna, Austria
Thanks for suggesting this new feature!
However, there is a lot missing before I can commit this:- Most importantly, I’m not convinced this will be useful for enough users to warrant adding this to the module. I’ll therefore wait until several more people have expressed interest/support or are following this issue.
- The issue summary isn’t very helpful like this. Please elaborate a bit, to enable others to find/understand your proposal.
- Like all new processors, this would need test coverage.
- Please do not use MRs in this project, as testing doesn’t work for them – see #3190024: Problem with test dependencies when testing issue forks → . Please upload patches instead.
- 🇮🇳India naveenvalecha New Delhi
This will also solve ✨ Index image style URLs Needs work
- Status changed to Needs review
over 1 year ago 7:20am 27 March 2023 The last submitted patch, 9: 3273159-9.patch, failed testing. View results →
The last submitted patch, 12: 3273159-12.patch, failed testing. View results →
- 🇮🇳India naveenvalecha New Delhi
It was a random failure. I re-tested it. Ready for review.
- 🇦🇹Austria drunken monkey Vienna, Austria
Thanks for adding the tests!
As mentioned, however, I’ll wait until more people express support for this before working further on this. - 🇮🇳India naveenvalecha New Delhi
Thanks for the update
I have tweeted about it https://twitter.com/naveenvalecha_/status/1646193183523753990.
Also slacked for the feedback in https://drupal.slack.com/archives/C3E9QDZ5M/p1681318102649399 I'd like to see this feature. When using search API via headless Drupal, we can only get the URL to a media field right now, like for a search teaser image.
There's no clear way to get a URL for an image style from search results data which would be useful for a headless frontend.
- 🇬🇧United Kingdom 4alldigital
I would also be interested in this feature. Having image-styles out of the box would be very useful for all headless app using Drupal as a CMS. This wold negate the usage and integration of additional 3rd party image generation services. I've been using the media style patch for a few years now for this feature.
Thanks for all the work.
- 🇮🇳India naveenvalecha New Delhi
Thanks for your feedback, @starfighter1 and @4alldigital
Would you care to RTBC if this works for you - 🇬🇧United Kingdom 4alldigital
@naveenvalecha I am not sure what the process it or requirements to "review" and "test", but if you can let me know on here I'll see if I can help. thanks.
- 🇮🇳India naveenvalecha New Delhi
@4alldigital Here's the page which explains how the issue is marked "Reviewed & Tested by community" https://www.drupal.org/docs/develop/issues/fields-and-other-parts-of-an-... →
- Status changed to RTBC
over 1 year ago 7:17am 24 May 2023 - Status changed to Needs review
over 1 year ago 2:44pm 27 May 2023 - last update
over 1 year ago 535 pass, 1 fail - 🇦🇹Austria drunken monkey Vienna, Austria
OK, especially when put together with ✨ Index image style URLs Needs work it does seem like there is enough interest for this to go forward.
Attached is a suggested revision, where I more clearly describe the processor and field. In effect, it’s a processor/field that lets users index custom values, potentially containing tokens. However, I don’t think the previous description really made that clear enough to users not familiar with this ticket.Still, I expect some confusion amongst users who just spot this field in the “Add fields” dialog, so any suggestions how to make the functionality clearer are welcome.
Finally, I amended the processor and expanded the tests to make sure this also works properly when multiple different types are indexed in the same index.
Please test/review!
The last submitted patch, 23: 3273159-23--custom_value_processor.patch, failed testing. View results →
- last update
over 1 year ago 535 pass, 1 fail The last submitted patch, 25: 3273159-25--custom_value_processor.patch, failed testing. View results →
- last update
over 1 year ago 537 pass - 🇦🇹Austria drunken monkey Vienna, Austria
Thanks for the test fix!
Nitpick: custom_value is a generic name. The custom value represents any string value that could be accepted, but we only allow tokenized text.
That was exactly my point: we don’t only allow tokenized text, entering a text with tokens in it (for whatever reason) would be completely fine as well.
If we later add options to specify different values per datasource or bundle, this could even become pretty useful completely without tokens.Anyways, I’m open for other suggestions, but I don’t think we should focus on the tokens this much. First priority is to give users, especially inexperienced ones, a clear idea of what the field will do.
Does anyone else have an opinion on this? - 🇮🇳India naveenvalecha New Delhi
@drunken monkey
Completely satisfied with your thoughts on #28
This looks me ready to be in :) - Status changed to RTBC
over 1 year ago 9:49pm 7 June 2023 - 🇦🇹Austria drunken monkey Vienna, Austria
Good to hear. Merged.
Thanks again, everyone! - Status changed to Fixed
over 1 year ago 12:51pm 17 June 2023 -
drunken monkey →
committed 329dac1e on 8.x-1.x authored by
naveenvalecha →
Issue #3273159 by naveenvalecha, drunken monkey: Added the "Custom value...
-
drunken monkey →
committed 329dac1e on 8.x-1.x authored by
naveenvalecha →
Automatically closed - issue fixed for 2 weeks with no activity.