\Drupal calls should be avoided in classes, use dependency injection instead

@Mingsong Created patch for 5.x as well.

Thanks @Maithri.

Merged.

This merge breaks the functionality. If FullcalendarViewPreprocess is a service then the dependencies should be added directly into the services.yml file, not with create method.

Something like this:

# View preprocess service.
fullcalendar_view.view_preprocess:
class: Drupal\fullcalendar_view\FullcalendarViewPreprocess
arguments: ['@language_manager', '@csrf_token', '@entity_type.manager', '@fullcalendar_view.timezone_conversion_service']

and the create method is not needed.

Thanks @cslevy.

Good point.

I believe the hot fix suggested by @cslevy from #15 patch the bug.

Please feel free to reopen it if it is still an issue.

Yes, the dev branch has fixed the issue! Thank you!

Automatically closed - issue fixed for 2 weeks with no activity.