UI: Rename 'menu items' to 'menu links' for more consistency

Menu items is more correct than menu links IMHO, you don't even have to add links to menus, you can add a bunch of buttons that don't link anywhere, or explicitly make a menu item a non link.

The issue summary is for fixing 'menu items' in the UI. I searched today and found no instances of 'menu items' in the UI.

(11.x)$ git grep -i 'menu item' | grep -v LICENSE.txt | grep -v migrate | grep -v ':\s*\*' | grep -v ':\s*\/\/' | grep -v ':\s*\/\*'
core/modules/menu_ui/tests/src/Functional/MenuUiTest.php:      $this->assertSession()->pageTextContains('Edit menu item');
core/modules/system/tests/modules/menu_test/menu_test.links.menu.yml:  title: 'Menu item title'
core/modules/system/tests/modules/menu_test/menu_test.links.menu.yml:  description: 'Menu item description parent'
core/modules/system/tests/modules/menu_test/menu_test.links.menu.yml:  title: 'Menu item with a regular description'
core/modules/system/tests/modules/menu_test/menu_test.links.menu.yml:  description: 'Menu item description text'
core/modules/system/tests/modules/menu_test/menu_test.links.menu.yml:  description: 'Menu item description parent'
core/modules/system/tests/modules/menu_test/menu_test.links.menu.yml:  description: 'Menu item description child2'
core/modules/system/tests/modules/menu_test/menu_test.links.menu.yml:  description: 'Menu item description child3'
core/modules/system/tests/modules/menu_test/menu_test.links.menu.yml:  description: 'Menu item description child4'
core/modules/system/tests/modules/menu_test/menu_test.links.menu.yml:  description: 'Menu item description child4 overview'
core/modules/system/tests/modules/menu_test/menu_test.links.menu.yml:  description: 'Menu item description grand child2'
core/modules/system/tests/modules/menu_test/menu_test.links.menu.yml:  description: 'Menu item description grand child3'
core/modules/system/tests/modules/menu_test/menu_test.links.menu.yml:  description: 'Menu item description grand child4'
core/modules/system/tests/modules/menu_test/menu_test.links.menu.yml:  description: 'Menu item description parent'
core/modules/system/tests/modules/menu_test/menu_test.links.menu.yml:  description: 'Menu item description child'
core/modules/system/tests/modules/menu_test/menu_test.links.menu.yml:  description: 'Menu item description parent'
core/modules/system/tests/modules/menu_test/menu_test.links.menu.yml:  description: 'Menu item description child'
core/modules/system/tests/modules/menu_test/menu_test.links.menu.yml:  description: 'Menu item description parent'
core/modules/system/tests/modules/menu_test/menu_test.links.menu.yml:  description: 'Menu item description child'
core/modules/system/tests/modules/menu_test/menu_test.routing.yml:    _title: 'Menu item with a regular description'
core/modules/system/tests/src/Functional/Menu/MenuRouterTest.php:    $this->assertSession()->pageTextContains('Menu item description text');
core/themes/claro/css/components/tabledrag.css:      using indentation (e.g. re-ordering menu items. */
core/themes/claro/css/components/tabledrag.pcss.css:      using indentation (e.g. re-ordering menu items. */

There are two instances in tests.

1. core/modules/menu_ui/tests/src/Functional/MenuUiTest.php: $this->assertSession()->pageTextContains('Edit menu item');
2. core/modules/system/tests/src/Functional/Menu/MenuRouterTest.php: $this->assertSession()->pageTextContains('Menu item description text');

The first one is in an if block in a test that is never reached. That method was committed years ago and may need to examined in another issue. The second is is testing strings from a test module, but the method, doTestDescriptionMenuItems, the assertion is in is never called.

I think this should be closed and another opened to look at the tests.

Opened 📌 Replace use of 'menu items' in tests Active

Moving this to RTBC because I'm wonder if it should be marked fixed for all the work that happened 10 years ago

Automatically closed - issue fixed for 2 weeks with no activity.