Contrib.social

UI: Rename 'menu items' to 'menu links' for more consistency

Open on Drupal.org →
Created on 2 August 2008, over 16 years ago
Updated 23 February 2023, almost 2 years ago

Problem/Motivation

There are still some lingering references to 'menu items' in the UI. These should be changed to 'menu links' for consistency.

Proposed resolution

Proposal: Change all occurrences of 'menu item' in the UI to 'menu link' for more consistency.

Remaining tasks

Locate and change UI strings

User interface changes

string change

API changes

n/a

Beta phase evaluation

<!--Uncomment the relevant rows for the issue. -->
📌 Task
Status

Needs work

Version

10.1 ✨

Component
Menu system  →

Last updated 1 day ago

Created by

🇬🇧United Kingdom Xano Southampton

Live updates comments and jobs are added and updated live.
  • Usability

    Makes Drupal easier to use. Preferred over UX, D7UX, etc.

  • Needs usability review

    Used to alert the usability topic maintainer(s) that an issue significantly affects (or has the potential to affect) the usability of Drupal, and their signoff is needed. When adding this tag, make it easy to review the issue. Make sure the issue summary describes the problem and the proposed solution. Screenshots usually help a lot! To get sign-off on issues with the "Needs usability review" tag, post about them in the #ux channel on Drupal Slack, and/or attend a UX meeting to demo the patch and get direct feedback from designers/UX folks/product management on next steps. If an issue represents a significant new feature, UI change, or change to the general "user experience" of Drupal, use Needs product manager review instead. See the scope of responsibilities for product managers.

  • Needs issue summary update

    Issue summaries save everyone time if they are kept up-to-date. See Update issue summary task instructions.

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Comment almost 2 years ago →
    🇺🇸United States trackleft2 Tucson, AZ 🇺🇸

    Menu items is more correct than menu links IMHO, you don't even have to add links to menus, you can add a bunch of buttons that don't link anywhere, or explicitly make a menu item a non link.

  • Status changed to Needs review 1 day ago
  • Comment 1 day ago →
    🇳🇿New Zealand quietone

    The issue summary is for fixing 'menu items' in the UI. I searched today and found no instances of 'menu items' in the UI. 

    (11.x)$ git grep -i 'menu item' | grep -v LICENSE.txt | grep -v migrate | grep -v ':\s*\*' | grep -v ':\s*\/\/' | grep -v ':\s*\/\*'
core/modules/menu_ui/tests/src/Functional/MenuUiTest.php:      $this->assertSession()->pageTextContains('Edit menu item');
core/modules/system/tests/modules/menu_test/menu_test.links.menu.yml:  title: 'Menu item title'
core/modules/system/tests/modules/menu_test/menu_test.links.menu.yml:  description: 'Menu item description parent'
core/modules/system/tests/modules/menu_test/menu_test.links.menu.yml:  title: 'Menu item with a regular description'
core/modules/system/tests/modules/menu_test/menu_test.links.menu.yml:  description: 'Menu item description text'
core/modules/system/tests/modules/menu_test/menu_test.links.menu.yml:  description: 'Menu item description parent'
core/modules/system/tests/modules/menu_test/menu_test.links.menu.yml:  description: 'Menu item description child2'
core/modules/system/tests/modules/menu_test/menu_test.links.menu.yml:  description: 'Menu item description child3'
core/modules/system/tests/modules/menu_test/menu_test.links.menu.yml:  description: 'Menu item description child4'
core/modules/system/tests/modules/menu_test/menu_test.links.menu.yml:  description: 'Menu item description child4 overview'
core/modules/system/tests/modules/menu_test/menu_test.links.menu.yml:  description: 'Menu item description grand child2'
core/modules/system/tests/modules/menu_test/menu_test.links.menu.yml:  description: 'Menu item description grand child3'
core/modules/system/tests/modules/menu_test/menu_test.links.menu.yml:  description: 'Menu item description grand child4'
core/modules/system/tests/modules/menu_test/menu_test.links.menu.yml:  description: 'Menu item description parent'
core/modules/system/tests/modules/menu_test/menu_test.links.menu.yml:  description: 'Menu item description child'
core/modules/system/tests/modules/menu_test/menu_test.links.menu.yml:  description: 'Menu item description parent'
core/modules/system/tests/modules/menu_test/menu_test.links.menu.yml:  description: 'Menu item description child'
core/modules/system/tests/modules/menu_test/menu_test.links.menu.yml:  description: 'Menu item description parent'
core/modules/system/tests/modules/menu_test/menu_test.links.menu.yml:  description: 'Menu item description child'
core/modules/system/tests/modules/menu_test/menu_test.routing.yml:    _title: 'Menu item with a regular description'
core/modules/system/tests/src/Functional/Menu/MenuRouterTest.php:    $this->assertSession()->pageTextContains('Menu item description text');
core/themes/claro/css/components/tabledrag.css:      using indentation (e.g. re-ordering menu items. */
core/themes/claro/css/components/tabledrag.pcss.css:      using indentation (e.g. re-ordering menu items. */

    There are two instances in tests.

    1. core/modules/menu_ui/tests/src/Functional/MenuUiTest.php: $this->assertSession()->pageTextContains('Edit menu item');
    2. core/modules/system/tests/src/Functional/Menu/MenuRouterTest.php: $this->assertSession()->pageTextContains('Menu item description text');

    The first one is in an if block in a test that is never reached. That method was committed years ago and may need to examined in another issue. The second is is testing strings from a test module, but the method, doTestDescriptionMenuItems, the assertion is in is never called.

    I think this should be closed and another opened to look at the tests.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024