Contrib.social

Replace use of 'menu items' in tests

Open on Drupal.org →
Created on 19 January 2025, 3 months ago

Problem/Motivation

Follow up from 📌 UI: Rename 'menu items' to 'menu links' for more consistency Needs work

from @quietone

There are two instances in tests.

core/modules/menu_ui/tests/src/Functional/MenuUiTest.php: $this->assertSession()->pageTextContains('Edit menu item');
core/modules/system/tests/src/Functional/Menu/MenuRouterTest.php: $this->assertSession()->pageTextContains('Menu item description text');
The first one is in an if block in a test that is never reached. That method was committed years ago and may need to examined in another issue. The second is is testing strings from a test module, but the method, doTestDescriptionMenuItems, the assertion is in is never called.

Steps to reproduce

N/A

Proposed resolution

Replace use of Menu items

Remaining tasks

Do it
Review

User interface changes

N/A

Introduced terminology

N/A

API changes

N/A

Data model changes

N/A

Release notes snippet

N/A

📌 Task
Status

Active

Version

11.0 🔥

Component

menu system

Created by

🇺🇸United States smustgrave

Live updates comments and jobs are added and updated live.
  • Novice

    It would make a good project for someone who is new to the Drupal contribution process. It's preferred over Newbie.

Sign in to follow issues

Merge Requests

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024