- 🇦🇺Australia mstrelan
Can we update the IS please with the standard template and remove everything that's crossed out? I'm finding it really hard to follow and know what this issue is about.
- last update
about 1 year ago Patch Failed to Apply - last update
about 1 year ago Custom Commands Failed - last update
about 1 year ago Custom Commands Failed - Status changed to Needs review
about 1 year ago 11:13am 24 May 2023 - last update
about 1 year ago Custom Commands Failed - last update
about 1 year ago Custom Commands Failed - Status changed to Needs work
about 1 year ago 2:58pm 24 May 2023 - 🇧🇪Belgium BramDriesen Belgium 🇧🇪
It would be very handy if everyone here the creates new patches provides an interdiff to show what they have changed. Tracking what changes between patches is next to impossible this way without them.
Even better, create a issue fork and a merge request.
There are coding style issues with the latest patch (see: https://www.drupal.org/pift-ci-job/2674454 → ). That's why the "custom commands" failed.
- Status changed to Needs review
12 months ago 7:21am 20 June 2023 - last update
12 months ago Custom Commands Failed - 🇮🇳India Suresh Prabhu Parkala Bangalore
Tried to remove the custom commands failure. Please review.
- Status changed to Needs work
12 months ago 7:47am 20 June 2023 The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
This does not mean that the patch needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- 🇮🇳India Prem Suthar gujrat
Fix The Failed Patch #23. also added the Interdiff For 23-25 Patch file .
- last update
12 months ago 29,493 pass, 2 fail - last update
12 months ago 29,493 pass, 2 fail - Status changed to Needs review
12 months ago 1:33pm 20 June 2023 - Status changed to Needs work
12 months ago 1:43pm 20 June 2023 - Status changed to Needs review
11 months ago 10:27am 6 July 2023 - last update
11 months ago Custom Commands Failed - 🇳🇱Netherlands Martijn de Wit 🇳🇱 The Netherlands
@Ajeet
You changed
if (strpos($form_key, '#') == 0) {
into
if (strpos($form_key, '#') === 0) {
But your new patch is also changing the document/patch structure with extra spaces etc.
Please provide an inter-div so the new patch can easily be reviewed. - Status changed to Needs work
11 months ago 10:54am 6 July 2023 - Assigned to Anchal_gupta
- Issue was unassigned.
- Status changed to Needs review
11 months ago 11:56am 6 July 2023 - last update
11 months ago 29,795 pass, 2 fail - 🇮🇳India Anchal_gupta
I have uploaded the patch.
To address the #29 comment and fixed CCF.
Please review. The last submitted patch, 32: 3037446-31.patch, failed testing. View results →
- Status changed to Needs work
7 months ago 1:57pm 30 October 2023 - 🇨🇦Canada mgifford Ottawa, Ontario
Also worth considering https://adamsilver.io/blog/how-to-highlight-required-and-optional-form-f...