Forms with required fields marked by asterisk do not have text explaining what the asterisk means

Can we update the IS please with the standard template and remove everything that's crossed out? I'm finding it really hard to follow and know what this issue is about.

Adding SC 3.3.2 & 1.3.1

Here is a reroll for Drupal 10.0.

Tried to fix failed custom command for #19.

It would be very handy if everyone here the creates new patches provides an interdiff to show what they have changed. Tracking what changes between patches is next to impossible this way without them.

Even better, create a issue fork and a merge request.

There are coding style issues with the latest patch (see: https://www.drupal.org/pift-ci-job/2674454 → ). That's why the "custom commands" failed.

Tried to remove the custom commands failure. Please review.

The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

This does not mean that the patch needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

Fix The Failed Patch #23. also added the Interdiff For 23-25 Patch file .

Failure seems legit. Did not review.

Please review.

@Ajeet

You changed
if (strpos($form_key, '#') == 0) {

into

if (strpos($form_key, '#') === 0) {

But your new patch is also changing the document/patch structure with extra spaces etc.
Please provide an inter-div so the new patch can easily be reviewed.

I have uploaded the patch.
To address the #29 comment and fixed CCF.
Please review.

The last submitted patch, 32: 3037446-31.patch, failed testing. View results →

Also worth considering https://adamsilver.io/blog/how-to-highlight-required-and-optional-form-f...

Hi, thanks for the patch, which I tried today.

It applies cleanly to Drupal (I would love to say which version but /admin/reports/status is timing out for me) but I see that it adds the message to the bottom of the form, instead of the top?

https://www.w3.org/WAI/WCAG22/Techniques/html/H90#example-2-using-an-ast... states...

It is important that the asterisk meaning is defined at the start of the form.

I just wondered if this was a deliberate decision or whether it's worth me creating a patch to put the message at the top of the form?

Best,

Chris

I moved the note to the beginning of the form and added a test.

The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

Failing AssetAggregationAcrossPagesTest seems unrelated.

Left some comments on the MR.

These screenshots were taken in the /contact page of the Olivero theme

required message field:

required subject field:

#41 provided screenshots of the status quo - there are * without the additional explanations requested in the issue summary.
Unless specified otherwise Needs screenshots is asking for screenshots of the implemented fix.

Here is the screenshot of the implemented fix.